tree f534e7d0fa40a2c591628ca2e248450c6f8f0108
parent dfabb598c3e4d4b2f264f3dcc30bd7bf3b0ebea2
author Lloyd Pique <lpique@google.com> 1531784156 -0700
committer Lloyd Pique <lpique@google.com> 1531854315 -0700

[SF] Fix unittest crash

Some of the values passed to HWC2::Display by FakeHwcDisplayInjector as
used by the test were passed by reference, with the reference being
owned by the injector.

However, the lifetime of the injector was effectively temporary, and so
the constructed Display instance ended up holding a reference to a dead
instance.

This patch uses statically constructed default values for those
parameters instead, so that the values will not be destroyed. The test
code can also still override the values used if non-default values are
ever desired.

It also adds a comment warning of the possibility so it hopefully does
not happen again.

Bug: 111454533
Test: Unit test runs without crashing
Change-Id: I8dfe6e31111a558a7892f0eef91bd96b8dd71f59