commit e8db871de7b26bf4fe7ae8d400c4a2c503cfe3a2
author Mathias Agopian <mathias@google.com> Mon Apr 16 19:30:56 2012 -0700
committer Mathias Agopian <mathias@google.com> Mon Apr 16 19:30:56 2012 -0700
tree 671257f4c9889723f876463d8c22e1c63b7d106a
parent 3aecbb0715cb6928e0530ff1e4caa9c0993cc371

double checked locking pattern is not safe on SMP

Change-Id: Ie6dd564bdcd45647cb4d62ab259462e3db112576

libs/binder/ProcessState.cpp

diff --git a/libs/binder/ProcessState.cpp b/libs/binder/ProcessState.cpp
index 9fa412c..5399e52 100644
--- a/libs/binder/ProcessState.cpp
+++ b/libs/binder/ProcessState.cpp
@@ -73,10 +73,11 @@
 
 sp<ProcessState> ProcessState::self()
 {
-    if (gProcess != NULL) return gProcess;
-    
-    AutoMutex _l(gProcessMutex);
-    if (gProcess == NULL) gProcess = new ProcessState;
+    Mutex::Autolock _l(gProcessMutex);
+    if (gProcess != NULL) {
+        return gProcess;
+    }
+    gProcess = new ProcessState;
     return gProcess;
 }