Gitiles
Code Review Sign In
review.blissroms.org / platform_frameworks_rs / 74de4db187fc370c9b6625134ae39df6655e7d72
commit74de4db187fc370c9b6625134ae39df6655e7d72[log] [tgz]
authorLuke Drummond <luke.drummond@codeplay.com>Thu Jul 14 16:18:47 2016 +0100
committerLuke Drummond <luke.drummond@codeplay.com>Tue Aug 30 17:41:33 2016 +0100
tree18130da9f34836c1c77602a502e4eff6a97b8ed0
parent4cd3bae214e0294ffb24c806376f02427ed0491e [diff]
[testsuite] Fix an egregious failure to report failure.

After I added the `--app-type` argument allowing a test file to be
runnable with multiple app types, I failed to realise that the running
total of pass/fails is actually implemented as a dictionary keyed by
test file name. Thus, if `test_something.py` fails for app type 'java',
but then succeeds for the JNI version, the final exit code of `run_tests.py`
will be successful as the success result for the second running of
`test_something.py` will overwrite the first as the dictionary key will
be identical

This patch fixes that issue, asserts that all new results are not yet
recorded, and fixes the running total of tests which clouded the issue.

Change-Id: If666cead11ad934aa324e06d46f1c733ccad6f1e
Signed-off-by: Luke Drummond <luke.drummond@codeplay.com>
4 files changed
tree: 18130da9f34836c1c77602a502e4eff6a97b8ed0
  1. api/
  2. cpp/
  3. cpu_ref/
  4. driver/
  5. java/
  6. scriptc/
  7. server/
  8. tests/
  9. Android.mk
  10. CleanSpec.mk
  11. libRS.map
  12. rs.h
  13. rs.spec
  14. rs_compat.spec
  15. rs_hal.h
  16. rsAllocation.cpp
  17. rsAllocation.h
  18. rsAnimation.cpp
  19. rsAnimation.h
  20. rsApiAllocation.cpp
  21. rsApiContext.cpp
  22. rsApiDevice.cpp
  23. rsApiElement.cpp
  24. rsApiFileA3D.cpp
  25. rsApiMesh.cpp
  26. rsApiType.cpp
  27. rsClosure.cpp
  28. rsClosure.h
  29. rsCompatibilityLib.cpp
  30. rsCompatibilityLib.h
  31. rsComponent.cpp
  32. rsComponent.h
  33. rsContext.cpp
  34. rsContext.h
  35. rsCppUtils.cpp
  36. rsCppUtils.h
  37. rsDebugHelper.h
  38. rsDefines.h
  39. rsDevice.cpp
  40. rsDevice.h
  41. rsDriverLoader.cpp
  42. rsElement.cpp
  43. rsElement.h
  44. rsEnv.h
  45. rsFBOCache.cpp
  46. rsFBOCache.h
  47. rsFifo.h
  48. rsFifoSocket.cpp
  49. rsFifoSocket.h
  50. rsFileA3D.cpp
  51. rsFileA3D.h
  52. rsFont.cpp
  53. rsFont.h
  54. rsg.spec
  55. rsg_generator.c
  56. rsgApi.cpp.rsg
  57. rsgApiFuncDecl.h.rsg
  58. rsgApiReplay.cpp.rsg
  59. rsgApiStructs.h.rsg
  60. rsGrallocConsumer.cpp
  61. rsGrallocConsumer.h
  62. rsInternalDefines.h
  63. rsList.h
  64. rsMap.h
  65. rsMatrix2x2.cpp
  66. rsMatrix2x2.h
  67. rsMatrix3x3.cpp
  68. rsMatrix3x3.h
  69. rsMatrix4x4.cpp
  70. rsMatrix4x4.h
  71. rsMesh.cpp
  72. rsMesh.h
  73. rsMutex.cpp
  74. rsMutex.h
  75. rsObjectBase.cpp
  76. rsObjectBase.h
  77. rsProgram.cpp
  78. rsProgram.h
  79. rsProgramBase.h
  80. rsProgramFragment.cpp
  81. rsProgramFragment.h
  82. rsProgramRaster.cpp
  83. rsProgramRaster.h
  84. rsProgramStore.cpp
  85. rsProgramStore.h
  86. rsProgramVertex.cpp
  87. rsProgramVertex.h
  88. rsRuntime.h
  89. rsSampler.cpp
  90. rsSampler.h
  91. rsScript.cpp
  92. rsScript.h
  93. rsScriptC.cpp
  94. rsScriptC.h
  95. rsScriptC_Lib.cpp
  96. rsScriptC_LibGL.cpp
  97. rsScriptGroup.cpp
  98. rsScriptGroup.h
  99. rsScriptGroup2.cpp
  100. rsScriptGroup2.h
  101. rsScriptGroupBase.h
  102. rsScriptIntrinsic.cpp
  103. rsScriptIntrinsic.h
  104. rsSignal.cpp
  105. rsSignal.h
  106. rsStream.cpp
  107. rsStream.h
  108. rsThreadIO.cpp
  109. rsThreadIO.h
  110. rsType.cpp
  111. rsType.h
  112. rsUtils.h
  113. run_rs_cts.sh
  114. spec.h
  115. spec.l
  116. update_rs_prebuilts.sh