Gitiles
Code Review Sign In
review.blissroms.org / platform_frameworks_rs / 11fd9ec1ab8dfa7ae45c6edeea48dddc4633efea
commit11fd9ec1ab8dfa7ae45c6edeea48dddc4633efea[log] [tgz]
authorMatt Wala <wala@google.com>Fri Jul 10 16:40:12 2015 -0700
committerMatt Wala <wala@google.com>Fri Jul 10 16:40:12 2015 -0700
treee4220a62bcabfad430e6bfc76f8bb2f324fcb409
parent5bf7ace8e25ca0c93822492c9ad7caed70a7c594 [diff]
CPU ref: Fix potential buffer over-read / uninitialized memory access.

GetCpuInfo() was reading /proc/cpuinfo into a string without properly
null terminating the result. The resulting unterminated string was
being passed to strstr().

Change the code to read the file with fgets(), which ensures the
result is null terminated. Also, document the GetCpuInfo() function
and the global variable that it sets.

Change-Id: I041331fdc25d79217ff7c1bf36a4aff2be8e0192
2 files changed
tree: e4220a62bcabfad430e6bfc76f8bb2f324fcb409
  1. api/
  2. cpp/
  3. cpu_ref/
  4. driver/
  5. java/
  6. scriptc/
  7. server/
  8. tests/
  9. Android.mk
  10. CleanSpec.mk
  11. rs.h
  12. rs.spec
  13. rs_hal.h
  14. rsAllocation.cpp
  15. rsAllocation.h
  16. rsAnimation.cpp
  17. rsAnimation.h
  18. rsClosure.cpp
  19. rsClosure.h
  20. rsCompatibilityLib.cpp
  21. rsCompatibilityLib.h
  22. rsComponent.cpp
  23. rsComponent.h
  24. rsContext.cpp
  25. rsContext.h
  26. rsCppUtils.cpp
  27. rsCppUtils.h
  28. rsDebugHelper.h
  29. rsDefines.h
  30. rsDevice.cpp
  31. rsDevice.h
  32. rsDriverLoader.cpp
  33. rsElement.cpp
  34. rsElement.h
  35. rsEnv.h
  36. rsFBOCache.cpp
  37. rsFBOCache.h
  38. rsFifo.h
  39. rsFifoSocket.cpp
  40. rsFifoSocket.h
  41. rsFileA3D.cpp
  42. rsFileA3D.h
  43. rsFont.cpp
  44. rsFont.h
  45. rsg.spec
  46. rsg_generator.c
  47. rsgApi.cpp.rsg
  48. rsgApiFuncDecl.h.rsg
  49. rsgApiReplay.cpp.rsg
  50. rsgApiStructs.h.rsg
  51. rsGrallocConsumer.cpp
  52. rsGrallocConsumer.h
  53. rsInternalDefines.h
  54. rsList.h
  55. rsMap.h
  56. rsMatrix2x2.cpp
  57. rsMatrix2x2.h
  58. rsMatrix3x3.cpp
  59. rsMatrix3x3.h
  60. rsMatrix4x4.cpp
  61. rsMatrix4x4.h
  62. rsMesh.cpp
  63. rsMesh.h
  64. rsMutex.cpp
  65. rsMutex.h
  66. rsObjectBase.cpp
  67. rsObjectBase.h
  68. rsProgram.cpp
  69. rsProgram.h
  70. rsProgramBase.h
  71. rsProgramFragment.cpp
  72. rsProgramFragment.h
  73. rsProgramRaster.cpp
  74. rsProgramRaster.h
  75. rsProgramStore.cpp
  76. rsProgramStore.h
  77. rsProgramVertex.cpp
  78. rsProgramVertex.h
  79. rsRuntime.h
  80. rsSampler.cpp
  81. rsSampler.h
  82. rsScript.cpp
  83. rsScript.h
  84. rsScriptC.cpp
  85. rsScriptC.h
  86. rsScriptC_Lib.cpp
  87. rsScriptC_LibGL.cpp
  88. rsScriptGroup.cpp
  89. rsScriptGroup.h
  90. rsScriptGroup2.cpp
  91. rsScriptGroup2.h
  92. rsScriptGroupBase.h
  93. rsScriptIntrinsic.cpp
  94. rsScriptIntrinsic.h
  95. rsSignal.cpp
  96. rsSignal.h
  97. rsStream.cpp
  98. rsStream.h
  99. rsThreadIO.cpp
  100. rsThreadIO.h
  101. rsType.cpp
  102. rsType.h
  103. rsUtils.h
  104. run_rs_cts.sh
  105. spec.h
  106. spec.l
  107. update_rs_prebuilts.sh