Gitiles
Code Review Sign In
review.blissroms.org / platform_frameworks_support / 0eb975ecd2ac1e25f9d8c6778664a2bd363b48f3
commit0eb975ecd2ac1e25f9d8c6778664a2bd363b48f3[log] [tgz]
authorSeigo Nonaka <nona@google.com>Fri Apr 21 16:04:41 2017 -0700
committerSeigo Nonaka <nona@google.com>Mon Apr 24 07:47:06 2017 -0700
tree4fe14fb38593b8608c1bacfd13a6024348a90eb6
parentf20be54c66a5d85e85a52209762bf8dd7cc25975 [diff]
Load the font data synchronously with timeout.

Since cancellation signal don't work on API 15 or before,
fetch the font data on the background thread with timeout.

Since nobody uses TypefaceCompat.create, removing interface
and change the callback thread from main thread to background thread
so that we can get the font data synchronously.

Bug: 37552479
Test: ./gradlew support-compat:connectedDebugAndroidTest
Test: ./gradlew support-compat:connectedCheck --info --daemon \
      -Pandroid.testInstrumentationRunnerArguments.class=\
      android.support.v4.content.res.FontResourcesParserCompatTest
Test: ./gradlew support-compat:connectedCheck --info --daemon \
      -Pandroid.testInstrumentationRunnerArguments.class=\
      android.support.v4.content.res.ResourcesCompatTest
Test: ./gradlew support-appcompat-v7:connectedCheck --info --daemon \
      -Pandroid.testInstrumentationRunnerArguments.class=\
      android.support.v7.widget.AppCompatTextViewTest

Change-Id: I6e2798b03476dfd85f1125c06c26d5e02b0f4c2e
2 files changed
tree: 4fe14fb38593b8608c1bacfd13a6024348a90eb6
  1. .idea/
  2. annotations/
  3. api/
  4. buildSrc/
  5. compat/
  6. core-ui/
  7. core-utils/
  8. customtabs/
  9. design/
  10. development/
  11. dynamic-animation/
  12. emoji/
  13. exifinterface/
  14. fragment/
  15. frameworks/
  16. gradle/
  17. graphics/
  18. media-compat/
  19. percent/
  20. recommendation/
  21. samples/
  22. scripts/
  23. testutils/
  24. transition/
  25. tv-provider/
  26. v13/
  27. v14/
  28. v17/
  29. v4/
  30. v7/
  31. wearable/
  32. .gitignore
  33. Android.mk
  34. build.gradle
  35. CleanSpec.mk
  36. droiddoc.mk
  37. gradle.properties
  38. gradlew
  39. pathmap.mk
  40. PREUPLOAD.cfg
  41. README.md
  42. settings.gradle
README.md

AOSP Support Library Contribution Guide

Accepted Types of Contributions

  • Bug fixes (needs a corresponding bug report in b.android.com)
  • Each bug fix is expected to come with tests
  • Fixing spelling errors
  • Updating documentation
  • Adding new tests to the area that is not currently covered by tests

We are not currently accepting new modules, features, or behavior changes.

Checking Out the Code

NOTE: You will need to use Linux or Mac OS. Building under Windows is not currently supported.

Follow the “Downloading the Source” guide to install and set up repo tool, but instead of running the listed repo commands to initialize the repository, run the folowing:

repo init -u https://android.googlesource.com/platform/manifest -b ub-supportlib-master

Now your repository is set to pull only what you need for building and running support library. Download the code (and grab a coffee while we pull down 7GB):

repo sync -j8 -c

You will use this command to sync your checkout in the future - it’s similar to git fetch

Using Android Studio

Open path/to/checkout/frameworks/support/ in Android Studio. Now you're ready edit, run, and test!

If you get “Unregistered VCS root detected” click “Add root” to enable git integration for Android Studio.

If you see any warnings (red underlines) run Build > Clean Project.

Optional - Full Build

You can do most of your work from Android Studio, however you can also build the full support library from command line:

cd path/to/checkout/frameworks/support/
./gradlew createArchive

Running Tests

Single Test Class or Method

  1. Open the desired test file in Android Studio.
  2. Right-click on a test class or @Test method name and select Run FooBarTest

Full Test Package

  1. In the project side panel open the desired module.
  2. Find the directory with the tests
  3. Right-click on the directory and select Run android.support.foobar

Running Sample Apps

Support library has a set of Android applications that exercise support library code. These applications can be useful when you want to debug a real running application, or reproduce a problem interactively, before writing test code.

These applications are named support-*-demos (e.g. support-4v-demos or support-leanback-demos. You can run them by clicking Run > Run ... and choosing the desired application.

Making a change

cd path/to/checkout/frameworks/support/
repo start my_branch_name .
(make needed modifications)
git commit -a
repo upload --current-branch .

If you see the following prompt, choose always:

Run hook scripts from https://android.googlesource.com/platform/manifest (yes/always/NO)?

Getting reviewed

  • After you run repo upload, open r.android.com
  • Sign in into your account (or create one if you do not have one yet)
  • Add an appropriate reviewer (use git log to find who did most modifications on the file you are fixing)