Gitiles
Code Review Sign In
review.blissroms.org / platform_frameworks_support / 3737d1dff953969c27652b49b010ea9902b3da4f
commit3737d1dff953969c27652b49b010ea9902b3da4f[log] [tgz]
authorYao, Yuxing <yaoyx@google.com>Tue Feb 06 15:33:42 2018 -0800
committerYao, Yuxing <yaoyx@google.com>Thu Feb 15 14:09:22 2018 -0800
treeb4c080dbabc8203a928771a6310525c9a6814776
parentc773511a187dffdbc21f4b2835c221fb5355dd52 [diff]
Support UXR in drawer and list item adapter.

Bug: 72970870
Fixes: 72160941
Test: ./gradlew :car:connectedCheck

make target for generating the stubs.jar is in ag/3569597.

- All tests will only run on automotive devices now due to implicit
dependency on android.car.

- We are ignoring exception from Car/UXR. Exception comes from car
connection failure, which should be handled in UxrManager so default
behavior (fully restricted vs. no restrictions) can be configured by
OEMs. Also this way 3rd party apps will not need to worry
about retrying.

- We are opting for unrestricted mode when UXR is unavailable. This is
more of a product decision to be made. So current decision is taking the
easier route.

- APIs in car support lib cannot expose APIs from android.car, namely
implementing OnUXRChangedListener, since android.car stub is only
available at compile time.

Change-Id: I4903838d9e21b3ba68508345bbbafa6fbab29ac4
22 files changed
tree: b4c080dbabc8203a928771a6310525c9a6814776
  1. .idea/
  2. annotations/
  3. api/
  4. app-toolkit/
  5. buildSrc/
  6. car/
  7. compat/
  8. content/
  9. core-ui/
  10. core-utils/
  11. customtabs/
  12. design/
  13. development/
  14. dynamic-animation/
  15. emoji/
  16. exifinterface/
  17. fragment/
  18. frameworks/
  19. gradle/
  20. graphics/
  21. jetifier/
  22. leanback/
  23. lifecycle/
  24. media-compat/
  25. paging/
  26. percent/
  27. persistence/
  28. preference-leanback/
  29. recommendation/
  30. recyclerview-selection/
  31. room/
  32. samples/
  33. scripts/
  34. testutils/
  35. transition/
  36. tv-provider/
  37. v13/
  38. v14/
  39. v4/
  40. v7/
  41. viewpager2/
  42. wear/
  43. webkit/
  44. webkit-codegen/
  45. .gitignore
  46. Android.mk
  47. build.gradle
  48. CleanSpec.mk
  49. gradle.properties
  50. gradlew
  51. LICENSE.txt
  52. makeFlatfootRepo.sh
  53. OWNERS
  54. pathmap.mk
  55. PREUPLOAD.cfg
  56. README.md
  57. settings.gradle
README.md

AOSP Support Library Contribution Guide

Accepted Types of Contributions

  • Bug fixes (needs a corresponding bug report in b.android.com)
  • Each bug fix is expected to come with tests
  • Fixing spelling errors
  • Updating documentation
  • Adding new tests to the area that is not currently covered by tests

We are not currently accepting new modules, features, or behavior changes.

Checking Out the Code

NOTE: You will need to use Linux or Mac OS. Building under Windows is not currently supported.

Follow the “Downloading the Source” guide to install and set up repo tool, but instead of running the listed repo commands to initialize the repository, run the folowing:

repo init -u https://android.googlesource.com/platform/manifest -b ub-supportlib-master

Now your repository is set to pull only what you need for building and running support library. Download the code (and grab a coffee while we pull down 7GB):

repo sync -j8 -c

You will use this command to sync your checkout in the future - it’s similar to git fetch

Using Android Studio

Open path/to/checkout/frameworks/support/ in Android Studio. Now you're ready edit, run, and test!

If you get “Unregistered VCS root detected” click “Add root” to enable git integration for Android Studio.

If you see any warnings (red underlines) run Build > Clean Project.

Optional - Full Build

You can do most of your work from Android Studio, however you can also build the full support library from command line:

cd path/to/checkout/frameworks/support/
./gradlew createArchive

Running Tests

Single Test Class or Method

  1. Open the desired test file in Android Studio.
  2. Right-click on a test class or @Test method name and select Run FooBarTest

Full Test Package

  1. In the project side panel open the desired module.
  2. Find the directory with the tests
  3. Right-click on the directory and select Run android.support.foobar

Running Sample Apps

Support library has a set of Android applications that exercise support library code. These applications can be useful when you want to debug a real running application, or reproduce a problem interactively, before writing test code.

These applications are named support-*-demos (e.g. support-4v-demos or support-leanback-demos. You can run them by clicking Run > Run ... and choosing the desired application.

Making a change

cd path/to/checkout/frameworks/support/
repo start my_branch_name .
(make needed modifications)
git commit -a
repo upload --current-branch .

If you see the following prompt, choose always:

Run hook scripts from https://android.googlesource.com/platform/manifest (yes/always/NO)?

Getting reviewed

  • After you run repo upload, open r.android.com
  • Sign in into your account (or create one if you do not have one yet)
  • Add an appropriate reviewer (use git log to find who did most modifications on the file you are fixing)