Gitiles
Code Review Sign In
review.blissroms.org / platform_frameworks_support / 508fbb7e7ced98b6101e76e61349565d0f0491f9
commit508fbb7e7ced98b6101e76e61349565d0f0491f9[log] [tgz]
authorAnthony Chen <ajchen@google.com>Tue May 29 14:33:56 2018 -0700
committerAnthony Chen <ajchen@google.com>Tue May 29 15:51:27 2018 -0700
treee77a31a4bd6960a55f7c0bfde1baf99322552dc6
parent8b570954bfda7269334dd47a81763d3910bf301d [diff]
Bring consistency to top margin for the scroll bar.

The PagedScrollBarView allows its top margin to be customized. However,
it was including a top padding with the same default value. This meant
that applications setting the top margin to 0 would still see the top
padding.

Refactor so that there is only margin affecting the top of the
PagedScrollBarView.

Fixes: 80433726
Test: build sample application and verify that top margin is the same as
before and can be customized.
Test: ./gradlew car:connectedCheck

Change-Id: I594bc9c0f94ab4e56d431ca610665676fbc4f8db
3 files changed
tree: e77a31a4bd6960a55f7c0bfde1baf99322552dc6
  1. .idea/
  2. annotations/
  3. api/
  4. app-toolkit/
  5. asynclayoutinflater/
  6. browser/
  7. buildSrc/
  8. car/
  9. cardview/
  10. collection/
  11. compat/
  12. content/
  13. coordinatorlayout/
  14. core/
  15. cursoradapter/
  16. customview/
  17. development/
  18. docs-fake/
  19. documentfile/
  20. drawerlayout/
  21. dynamic-animation/
  22. emoji/
  23. exifinterface/
  24. fragment/
  25. frameworks/
  26. gradle/
  27. graphics/
  28. gridlayout/
  29. heifwriter/
  30. interpolator/
  31. jetifier/
  32. leanback/
  33. leanback-preference/
  34. legacy/
  35. lifecycle/
  36. loader/
  37. localbroadcastmanager/
  38. media/
  39. media-widget/
  40. mediarouter/
  41. navigation/
  42. paging/
  43. palette/
  44. percent/
  45. persistence/
  46. preference/
  47. print/
  48. recommendation/
  49. recyclerview-selection/
  50. room/
  51. samples/
  52. scripts/
  53. slices/
  54. slidingpanelayout/
  55. swiperefreshlayout/
  56. testutils/
  57. testutils-ktx/
  58. textclassifier/
  59. transition/
  60. tv-provider/
  61. v7/
  62. viewpager/
  63. viewpager2/
  64. wear/
  65. webkit/
  66. webkit-codegen/
  67. work/
  68. .gitignore
  69. adding-support-library-as-included-build.md
  70. build.gradle
  71. gradle.properties
  72. gradlew
  73. include-composite-deps.gradle
  74. include-support-library.gradle
  75. LICENSE.txt
  76. OWNERS
  77. PREUPLOAD.cfg
  78. README.md
  79. settings.gradle
README.md

AOSP Support Library Contribution Guide

Accepted Types of Contributions

  • Bug fixes (needs a corresponding bug report in b.android.com)
  • Each bug fix is expected to come with tests
  • Fixing spelling errors
  • Updating documentation
  • Adding new tests to the area that is not currently covered by tests

We are not currently accepting new modules, features, or behavior changes.

Checking Out the Code

NOTE: You will need to use Linux or Mac OS. Building under Windows is not currently supported.

Follow the “Downloading the Source” guide to install and set up repo tool, but instead of running the listed repo commands to initialize the repository, run the folowing:

repo init -u https://android.googlesource.com/platform/manifest -b ub-supportlib-master

Now your repository is set to pull only what you need for building and running support library. Download the code (and grab a coffee while we pull down 7GB):

repo sync -j8 -c

You will use this command to sync your checkout in the future - it’s similar to git fetch

Using Android Studio

Open path/to/checkout/frameworks/support/ in Android Studio. Now you're ready edit, run, and test!

If you get “Unregistered VCS root detected” click “Add root” to enable git integration for Android Studio.

If you see any warnings (red underlines) run Build > Clean Project.

Builds

Full Build (Optional)

You can do most of your work from Android Studio, however you can also build the full support library from command line:

cd path/to/checkout/frameworks/support/
./gradlew createArchive

Building Support Library as part of your App build

If you intend to repeatedly make changes to Support Library and to wish to see the results in your app, and you don't want to have to repeatedly build them as separate Gradle projects, you can configure your app build to build Support Library too

Running Tests

Single Test Class or Method

  1. Open the desired test file in Android Studio.
  2. Right-click on a test class or @Test method name and select Run FooBarTest

Full Test Package

  1. In the project side panel open the desired module.
  2. Find the directory with the tests
  3. Right-click on the directory and select Run android.support.foobar

Running Sample Apps

Support library has a set of Android applications that exercise support library code. These applications can be useful when you want to debug a real running application, or reproduce a problem interactively, before writing test code.

These applications are named support-*-demos (e.g. support-4v-demos or support-leanback-demos. You can run them by clicking Run > Run ... and choosing the desired application.

Making a change

cd path/to/checkout/frameworks/support/
repo start my_branch_name .
(make needed modifications)
git commit -a
repo upload --current-branch .

If you see the following prompt, choose always:

Run hook scripts from https://android.googlesource.com/platform/manifest (yes/always/NO)?

Getting reviewed

  • After you run repo upload, open r.android.com
  • Sign in into your account (or create one if you do not have one yet)
  • Add an appropriate reviewer (use git log to find who did most modifications on the file you are fixing)