Gitiles
Code Review Sign In
review.blissroms.org / platform_frameworks_support / 313fd0518c2e90dd2372262042e619d26bae9b9c
commit313fd0518c2e90dd2372262042e619d26bae9b9c[log] [tgz]
authorClara Bayarri <clarabayarri@google.com>Fri Jan 19 14:28:14 2018 +0000
committerClara Bayarri <clarabayarri@google.com>Mon Jan 22 12:34:55 2018 +0000
treebd54260e2e032547557682a43ac536b41bac3a43
parent731b13dc17ec2ef2d83efdffde6e1c22a2bd2190 [diff]
Fix crash in AppCompatEditText#getText

Because this method can potentially be called before the TextView
constructor runs, we can't call setText safely, as it will cause
other un-initialized variables to fail. In P we can do a best-effort
to return an editable version of the given text, but pre-P we can't
distinguish between the text still being un-initialized and set to
a non-editable value to we will just return null for both.

Note this only happens when you call getText before the constructor
for TextView can finish running, so should be a very rare case.

Bug: 71638589
Test: AppCompatEditTextTest
Change-Id: I5c6139cecde9ff50e7f81f340b9c5623189b38eb
2 files changed
tree: bd54260e2e032547557682a43ac536b41bac3a43
  1. .idea/
  2. annotations/
  3. api/
  4. app-toolkit/
  5. buildSrc/
  6. car/
  7. compat/
  8. content/
  9. core-ui/
  10. core-utils/
  11. customtabs/
  12. design/
  13. development/
  14. dynamic-animation/
  15. emoji/
  16. exifinterface/
  17. fragment/
  18. frameworks/
  19. gradle/
  20. graphics/
  21. jetifier/
  22. leanback/
  23. lifecycle/
  24. media-compat/
  25. paging/
  26. percent/
  27. persistence/
  28. preference-leanback/
  29. recommendation/
  30. recyclerview-selection/
  31. room/
  32. samples/
  33. scripts/
  34. slices/
  35. testutils/
  36. transition/
  37. tv-provider/
  38. v13/
  39. v14/
  40. v4/
  41. v7/
  42. viewpager2/
  43. wear/
  44. webkit/
  45. webkit-codegen/
  46. .gitignore
  47. adding-support-library-as-included-build.md
  48. Android.mk
  49. build.gradle
  50. CleanSpec.mk
  51. gradle.properties
  52. gradlew
  53. include-composite-deps.gradle
  54. include-support-library.gradle
  55. LICENSE.txt
  56. makeFlatfootRepo.sh
  57. OWNERS
  58. pathmap.mk
  59. PREUPLOAD.cfg
  60. README.md
  61. settings.gradle
README.md

AOSP Support Library Contribution Guide

Accepted Types of Contributions

  • Bug fixes (needs a corresponding bug report in b.android.com)
  • Each bug fix is expected to come with tests
  • Fixing spelling errors
  • Updating documentation
  • Adding new tests to the area that is not currently covered by tests

We are not currently accepting new modules, features, or behavior changes.

Checking Out the Code

NOTE: You will need to use Linux or Mac OS. Building under Windows is not currently supported.

Follow the “Downloading the Source” guide to install and set up repo tool, but instead of running the listed repo commands to initialize the repository, run the folowing:

repo init -u https://android.googlesource.com/platform/manifest -b ub-supportlib-master

Now your repository is set to pull only what you need for building and running support library. Download the code (and grab a coffee while we pull down 7GB):

repo sync -j8 -c

You will use this command to sync your checkout in the future - it’s similar to git fetch

Using Android Studio

Open path/to/checkout/frameworks/support/ in Android Studio. Now you're ready edit, run, and test!

If you get “Unregistered VCS root detected” click “Add root” to enable git integration for Android Studio.

If you see any warnings (red underlines) run Build > Clean Project.

Builds

Full Build (Optional)

You can do most of your work from Android Studio, however you can also build the full support library from command line:

cd path/to/checkout/frameworks/support/
./gradlew createArchive

Building Support Library as part of your App build

If you intend to repeatedly make changes to Support Library and to wish to see the results in your app, and you don't want to have to repeatedly build them as separate Gradle projects, you can configure your app build to build Support Library too

Running Tests

Single Test Class or Method

  1. Open the desired test file in Android Studio.
  2. Right-click on a test class or @Test method name and select Run FooBarTest

Full Test Package

  1. In the project side panel open the desired module.
  2. Find the directory with the tests
  3. Right-click on the directory and select Run android.support.foobar

Running Sample Apps

Support library has a set of Android applications that exercise support library code. These applications can be useful when you want to debug a real running application, or reproduce a problem interactively, before writing test code.

These applications are named support-*-demos (e.g. support-4v-demos or support-leanback-demos. You can run them by clicking Run > Run ... and choosing the desired application.

Making a change

cd path/to/checkout/frameworks/support/
repo start my_branch_name .
(make needed modifications)
git commit -a
repo upload --current-branch .

If you see the following prompt, choose always:

Run hook scripts from https://android.googlesource.com/platform/manifest (yes/always/NO)?

Getting reviewed

  • After you run repo upload, open r.android.com
  • Sign in into your account (or create one if you do not have one yet)
  • Add an appropriate reviewer (use git log to find who did most modifications on the file you are fixing)