Gitiles
Code Review Sign In
review.blissroms.org / platform_frameworks_support / e855454acac8e6d87aaa8b3e67731fb83a22e882
commite855454acac8e6d87aaa8b3e67731fb83a22e882[log] [tgz]
authorAnthony Chen <ajchen@google.com>Fri Apr 20 11:31:37 2018 -0700
committerAnthony Chen <ajchen@google.com>Fri Apr 20 14:01:19 2018 -0700
tree94be6fbc335d851c2aa60196ed5518af0f230e63
parente2826f1d39567caaee27511c526100ec28ce52c8 [diff]
Remove struct used to hold dialog data.

Instead, just access this data off the Builder directly. If the values
need to be held on to longer than the constructor, then the dialog
should create individual fields for this.

The reasoning is that this reduces abstraction. The DialogData objects
also allowed values to change after its creation. This works for
Builder, but should not be the case for the dialog itself.

Refactoring in this way ensures the expected behavior.

Fixes: 78349123
Test: test on demo app for CarAlertDialog and CarListDialog. Ensured
functionality is still the same with no crashes.

Change-Id: I9316e76ca8691506fdab6726388a56c274f87014
2 files changed
tree: 94be6fbc335d851c2aa60196ed5518af0f230e63
  1. .idea/
  2. annotations/
  3. api/
  4. app-toolkit/
  5. asynclayoutinflater/
  6. browser/
  7. buildSrc/
  8. car/
  9. cardview/
  10. collection/
  11. compat/
  12. content/
  13. coordinatorlayout/
  14. cursoradapter/
  15. customview/
  16. development/
  17. documentfile/
  18. drawerlayout/
  19. dynamic-animation/
  20. emoji/
  21. exifinterface/
  22. fragment/
  23. frameworks/
  24. gradle/
  25. graphics/
  26. gridlayout/
  27. heifwriter/
  28. interpolator/
  29. jetifier/
  30. leanback/
  31. leanback-preference/
  32. legacy/
  33. lifecycle/
  34. loader/
  35. localbroadcastmanager/
  36. media/
  37. media-widget/
  38. mediarouter/
  39. navigation/
  40. paging/
  41. palette/
  42. percent/
  43. persistence/
  44. preference/
  45. print/
  46. recommendation/
  47. recyclerview-selection/
  48. room/
  49. samples/
  50. scripts/
  51. slices/
  52. slidingpanelayout/
  53. swiperefreshlayout/
  54. testutils/
  55. textclassifier/
  56. transition/
  57. tv-provider/
  58. v7/
  59. viewpager/
  60. viewpager2/
  61. wear/
  62. webkit/
  63. webkit-codegen/
  64. .gitignore
  65. adding-support-library-as-included-build.md
  66. build.gradle
  67. gradle.properties
  68. gradlew
  69. include-composite-deps.gradle
  70. include-support-library.gradle
  71. LICENSE.txt
  72. OWNERS
  73. PREUPLOAD.cfg
  74. README.md
  75. settings.gradle
README.md

AOSP Support Library Contribution Guide

Accepted Types of Contributions

  • Bug fixes (needs a corresponding bug report in b.android.com)
  • Each bug fix is expected to come with tests
  • Fixing spelling errors
  • Updating documentation
  • Adding new tests to the area that is not currently covered by tests

We are not currently accepting new modules, features, or behavior changes.

Checking Out the Code

NOTE: You will need to use Linux or Mac OS. Building under Windows is not currently supported.

Follow the “Downloading the Source” guide to install and set up repo tool, but instead of running the listed repo commands to initialize the repository, run the folowing:

repo init -u https://android.googlesource.com/platform/manifest -b ub-supportlib-master

Now your repository is set to pull only what you need for building and running support library. Download the code (and grab a coffee while we pull down 7GB):

repo sync -j8 -c

You will use this command to sync your checkout in the future - it’s similar to git fetch

Using Android Studio

Open path/to/checkout/frameworks/support/ in Android Studio. Now you're ready edit, run, and test!

If you get “Unregistered VCS root detected” click “Add root” to enable git integration for Android Studio.

If you see any warnings (red underlines) run Build > Clean Project.

Builds

Full Build (Optional)

You can do most of your work from Android Studio, however you can also build the full support library from command line:

cd path/to/checkout/frameworks/support/
./gradlew createArchive

Building Support Library as part of your App build

If you intend to repeatedly make changes to Support Library and to wish to see the results in your app, and you don't want to have to repeatedly build them as separate Gradle projects, you can configure your app build to build Support Library too

Running Tests

Single Test Class or Method

  1. Open the desired test file in Android Studio.
  2. Right-click on a test class or @Test method name and select Run FooBarTest

Full Test Package

  1. In the project side panel open the desired module.
  2. Find the directory with the tests
  3. Right-click on the directory and select Run android.support.foobar

Running Sample Apps

Support library has a set of Android applications that exercise support library code. These applications can be useful when you want to debug a real running application, or reproduce a problem interactively, before writing test code.

These applications are named support-*-demos (e.g. support-4v-demos or support-leanback-demos. You can run them by clicking Run > Run ... and choosing the desired application.

Making a change

cd path/to/checkout/frameworks/support/
repo start my_branch_name .
(make needed modifications)
git commit -a
repo upload --current-branch .

If you see the following prompt, choose always:

Run hook scripts from https://android.googlesource.com/platform/manifest (yes/always/NO)?

Getting reviewed

  • After you run repo upload, open r.android.com
  • Sign in into your account (or create one if you do not have one yet)
  • Add an appropriate reviewer (use git log to find who did most modifications on the file you are fixing)