Gitiles
Code Review Sign In
review.blissroms.org / platform_frameworks_support / b2959d2604c82a2b73e81eac3e19f430e7ac4a1a
commitb2959d2604c82a2b73e81eac3e19f430e7ac4a1a[log] [tgz]
authorSeigo Nonaka <nona@google.com>Tue May 16 12:40:54 2017 -0700
committerSeigo Nonaka <nona@google.com>Tue May 23 19:44:25 2017 +0900
tree03d4c4e6d46d72720cb935db75bca846f92e4bd4
parent68fd3a6145d75ae8419b2ba92fc23295ce7d9b3e [diff]
Clean Up: Groundwork for making TypefaceCompat implementation for API24.

This CL does:
- Remove Context argument from TypefaceCompatBaseImpl constructor so
  that we can switch the implementation statically and lock-free.
- Move cache mechanism from TypefaceCompatBaseImpl to TypefaceCompat
  which is independent from the implementation.
- LruCache is thread-safe. Removing lock.

Bug: 37493347
Test: ./gradlew support-compat:connectedDebugAndroidTest
      on API 16, 17, 18, 19, 21, 22, 23, 24, 25, O
Test: ./gradlew support-appcompat-v7:connectedDebugAndroidTest
      on API 16, 17, 18, 19, 21, 22, 23, 24, 25, O

Change-Id: I2ba08a610f29749b94292c149d47d1d43104532e
2 files changed
tree: 03d4c4e6d46d72720cb935db75bca846f92e4bd4
  1. .idea/
  2. annotations/
  3. api/
  4. buildSrc/
  5. compat/
  6. core-ui/
  7. core-utils/
  8. customtabs/
  9. design/
  10. development/
  11. dynamic-animation/
  12. emoji/
  13. exifinterface/
  14. fragment/
  15. frameworks/
  16. gradle/
  17. graphics/
  18. media-compat/
  19. percent/
  20. recommendation/
  21. samples/
  22. scripts/
  23. testutils/
  24. transition/
  25. tv-provider/
  26. v13/
  27. v14/
  28. v17/
  29. v4/
  30. v7/
  31. wear/
  32. .gitignore
  33. Android.mk
  34. build.gradle
  35. CleanSpec.mk
  36. droiddoc.mk
  37. gradle.properties
  38. gradlew
  39. LICENSE.txt
  40. pathmap.mk
  41. PREUPLOAD.cfg
  42. README.md
  43. settings.gradle
README.md

AOSP Support Library Contribution Guide

Accepted Types of Contributions

  • Bug fixes (needs a corresponding bug report in b.android.com)
  • Each bug fix is expected to come with tests
  • Fixing spelling errors
  • Updating documentation
  • Adding new tests to the area that is not currently covered by tests

We are not currently accepting new modules, features, or behavior changes.

Checking Out the Code

NOTE: You will need to use Linux or Mac OS. Building under Windows is not currently supported.

Follow the “Downloading the Source” guide to install and set up repo tool, but instead of running the listed repo commands to initialize the repository, run the folowing:

repo init -u https://android.googlesource.com/platform/manifest -b ub-supportlib-master

Now your repository is set to pull only what you need for building and running support library. Download the code (and grab a coffee while we pull down 7GB):

repo sync -j8 -c

You will use this command to sync your checkout in the future - it’s similar to git fetch

Using Android Studio

Open path/to/checkout/frameworks/support/ in Android Studio. Now you're ready edit, run, and test!

If you get “Unregistered VCS root detected” click “Add root” to enable git integration for Android Studio.

If you see any warnings (red underlines) run Build > Clean Project.

Optional - Full Build

You can do most of your work from Android Studio, however you can also build the full support library from command line:

cd path/to/checkout/frameworks/support/
./gradlew createArchive

Running Tests

Single Test Class or Method

  1. Open the desired test file in Android Studio.
  2. Right-click on a test class or @Test method name and select Run FooBarTest

Full Test Package

  1. In the project side panel open the desired module.
  2. Find the directory with the tests
  3. Right-click on the directory and select Run android.support.foobar

Running Sample Apps

Support library has a set of Android applications that exercise support library code. These applications can be useful when you want to debug a real running application, or reproduce a problem interactively, before writing test code.

These applications are named support-*-demos (e.g. support-4v-demos or support-leanback-demos. You can run them by clicking Run > Run ... and choosing the desired application.

Making a change

cd path/to/checkout/frameworks/support/
repo start my_branch_name .
(make needed modifications)
git commit -a
repo upload --current-branch .

If you see the following prompt, choose always:

Run hook scripts from https://android.googlesource.com/platform/manifest (yes/always/NO)?

Getting reviewed

  • After you run repo upload, open r.android.com
  • Sign in into your account (or create one if you do not have one yet)
  • Add an appropriate reviewer (use git log to find who did most modifications on the file you are fixing)