Gitiles
Code Review Sign In
review.blissroms.org / platform_frameworks_support / cac4c3f2757db4f618b57af443bc5dc869128986
commitcac4c3f2757db4f618b57af443bc5dc869128986[log] [tgz]
authorVladislav Kaznacheev <kaznacheev@google.com>Wed Mar 08 10:00:18 2017 -0800
committerVladislav Kaznacheev <kaznacheev@google.com>Wed Mar 08 10:00:18 2017 -0800
tree9885436cec4bb0fc877afaaa87c4178a0e2287c7
parent9e9fa070c89cd4bf63d0e0becfb8bf3896547f6f [diff]
Align a cascading submenu to its parent menu item

Currently the submenu might become misaligned
when the parent menu moves. Fix this by anchoring
the submenu to the parent menu item directly.

For API<26 align to the parent item using offsets,
which works well in most cases.

Bug: 35768002
Test: manual
Change-Id: Ib22ffb36f908322a7ada8aa26fa801a2a1dc9ca6
2 files changed
tree: 9885436cec4bb0fc877afaaa87c4178a0e2287c7
  1. .idea/
  2. annotations/
  3. api/
  4. buildSrc/
  5. compat/
  6. core-ui/
  7. core-utils/
  8. customtabs/
  9. design/
  10. development/
  11. dynamic-animation/
  12. exifinterface/
  13. fragment/
  14. frameworks/
  15. gradle/
  16. graphics/
  17. instantvideo/
  18. media-compat/
  19. percent/
  20. previewsdk/
  21. recommendation/
  22. samples/
  23. scripts/
  24. transition/
  25. tv-provider/
  26. v13/
  27. v14/
  28. v17/
  29. v4/
  30. v7/
  31. wearable/
  32. .gitignore
  33. Android.mk
  34. build.gradle
  35. CleanSpec.mk
  36. gradle.properties
  37. gradlew
  38. PREUPLOAD.cfg
  39. README.md
  40. settings.gradle
README.md

AOSP Support Library Contribution Guide

Accepted Types of Contributions

  • Bug fixes (needs a corresponding bug report in b.android.com)
  • Each bug fix is expected to come with tests
  • Fixing spelling errors
  • Updating documentation
  • Adding new tests to the area that is not currently covered by tests

We are not currently accepting new modules, features, or behavior changes.

Checking Out the Code

NOTE: You will need to use Linux or Mac OS. Building under Windows is not currently supported.

Follow the “Downloading the Source” guide to install and set up repo tool, but instead of running the listed repo commands to initialize the repository, run the folowing:

repo init -u https://android.googlesource.com/platform/manifest -b ub-supportlib-master

Now your repository is set to pull only what you need for building and running support library. Download the code (and grab a coffee while we pull down 7GB):

repo sync -j8 -c

You will use this command to sync your checkout in the future - it’s similar to git fetch

Using Android Studio

Open path/to/checkout/frameworks/support/ in Android Studio. Now you're ready edit, run, and test!

If you get “Unregistered VCS root detected” click “Add root” to enable git integration for Android Studio.

If you see any warnings (red underlines) run Build > Clean Project.

Optional - Full Build

You can do most of your work from Android Studio, however you can also build the full support library from command line:

cd path/to/checkout/frameworks/support/
./gradlew createArchive

Running Tests

Single Test Class or Method

  1. Open the desired test file in Android Studio.
  2. Right-click on a test class or @Test method name and select Run FooBarTest

Full Test Package

  1. In the project side panel open the desired module.
  2. Find the directory with the tests
  3. Right-click on the directory and select Run android.support.foobar

Running Sample Apps

Support library has a set of Android applications that exercise support library code. These applications can be useful when you want to debug a real running application, or reproduce a problem interactively, before writing test code.

These applications are named support-*-demos (e.g. support-4v-demos or support-leanback-demos. You can run them by clicking Run > Run ... and choosing the desired application.

Making a change

cd path/to/checkout/frameworks/support/
repo start my_branch_name .
(make needed modifications)
git commit -a
repo upload --current-branch .

If you see the following prompt, choose always:

Run hook scripts from https://android.googlesource.com/platform/manifest (yes/always/NO)?

Getting reviewed

  • After you run repo upload, open r.android.com
  • Sign in into your account (or create one if you do not have one yet)
  • Add an appropriate reviewer (use git log to find who did most modifications on the file you are fixing)