Gitiles
Code Review Sign In
review.blissroms.org / platform_frameworks_support / 66fd2b18d367c602d84b3fa7220462b4228fae43
commit66fd2b18d367c602d84b3fa7220462b4228fae43[log] [tgz]
authorSumir Kataria <sumir@google.com>Thu Jan 25 13:04:20 2018 -0800
committerSumir Kataria <sumir@google.com>Thu Jan 25 13:49:24 2018 -0800
tree47ed62f1df13c0a048eb753dfa0c53279bcd5da7
parente0a67758772780cfe965d92a9a33f050c47d5d3d [diff]
Change WorkStatus to an enum.

Lots of files were affected, but the change is pretty
straightforward. The only thing worth noting is that
Room SQL queries don't automatically typeconvert the
enum, so I made some int constants to back the enums
that I used in the SQL queries. You can find that in
EnumTypeConverters.java (which I will use for other
conversions in the future, like BackoffPolicy).

Also renamed getStatusById -> getStatus.

Test: Fixed and ran tests.
Change-Id: I57d293eafea07f9e661dfbdb28fdc82cbc301273
24 files changed
tree: 47ed62f1df13c0a048eb753dfa0c53279bcd5da7
  1. .idea/
  2. annotations/
  3. api/
  4. app-toolkit/
  5. background/
  6. buildSrc/
  7. compat/
  8. content/
  9. core-ui/
  10. core-utils/
  11. customtabs/
  12. design/
  13. development/
  14. dynamic-animation/
  15. emoji/
  16. exifinterface/
  17. fragment/
  18. frameworks/
  19. gradle/
  20. graphics/
  21. lifecycle/
  22. media-compat/
  23. media-compat-test-client/
  24. media-compat-test-lib/
  25. media-compat-test-service/
  26. paging/
  27. percent/
  28. persistence/
  29. recommendation/
  30. room/
  31. samples/
  32. scripts/
  33. testutils/
  34. transition/
  35. tv-provider/
  36. v13/
  37. v14/
  38. v17/
  39. v4/
  40. v7/
  41. wear/
  42. .gitignore
  43. Android.mk
  44. build.gradle
  45. CleanSpec.mk
  46. gradle.properties
  47. gradlew
  48. LICENSE.txt
  49. makeFlatfootRepo.sh
  50. OWNERS
  51. pathmap.mk
  52. PREUPLOAD.cfg
  53. README.md
  54. settings.gradle
README.md

AOSP Support Library Contribution Guide

Accepted Types of Contributions

  • Bug fixes (needs a corresponding bug report in b.android.com)
  • Each bug fix is expected to come with tests
  • Fixing spelling errors
  • Updating documentation
  • Adding new tests to the area that is not currently covered by tests

We are not currently accepting new modules, features, or behavior changes.

Checking Out the Code

NOTE: You will need to use Linux or Mac OS. Building under Windows is not currently supported.

Follow the “Downloading the Source” guide to install and set up repo tool, but instead of running the listed repo commands to initialize the repository, run the folowing:

repo init -u https://android.googlesource.com/platform/manifest -b ub-supportlib-master

Now your repository is set to pull only what you need for building and running support library. Download the code (and grab a coffee while we pull down 7GB):

repo sync -j8 -c

You will use this command to sync your checkout in the future - it’s similar to git fetch

Using Android Studio

Open path/to/checkout/frameworks/support/ in Android Studio. Now you're ready edit, run, and test!

If you get “Unregistered VCS root detected” click “Add root” to enable git integration for Android Studio.

If you see any warnings (red underlines) run Build > Clean Project.

Optional - Full Build

You can do most of your work from Android Studio, however you can also build the full support library from command line:

cd path/to/checkout/frameworks/support/
./gradlew createArchive

Running Tests

Single Test Class or Method

  1. Open the desired test file in Android Studio.
  2. Right-click on a test class or @Test method name and select Run FooBarTest

Full Test Package

  1. In the project side panel open the desired module.
  2. Find the directory with the tests
  3. Right-click on the directory and select Run android.support.foobar

Running Sample Apps

Support library has a set of Android applications that exercise support library code. These applications can be useful when you want to debug a real running application, or reproduce a problem interactively, before writing test code.

These applications are named support-*-demos (e.g. support-4v-demos or support-leanback-demos. You can run them by clicking Run > Run ... and choosing the desired application.

Making a change

cd path/to/checkout/frameworks/support/
repo start my_branch_name .
(make needed modifications)
git commit -a
repo upload --current-branch .

If you see the following prompt, choose always:

Run hook scripts from https://android.googlesource.com/platform/manifest (yes/always/NO)?

Getting reviewed

  • After you run repo upload, open r.android.com
  • Sign in into your account (or create one if you do not have one yet)
  • Add an appropriate reviewer (use git log to find who did most modifications on the file you are fixing)