Gitiles
Code Review Sign In
review.blissroms.org / platform_frameworks_support / 610473e5bb1295c992f8be92311bbfad96f03311
commit610473e5bb1295c992f8be92311bbfad96f03311[log] [tgz]
authorGustav Sennton <gsennton@google.com>Wed Apr 11 17:40:55 2018 +0100
committerGustav Sennton <gsennton@google.com>Mon Apr 16 22:32:13 2018 +0100
tree689bb2e485005b8cd08a5a262d7f32e5746232a4
parent75c07d2a0e56e6e8c4302cba3c8f3df7b0783a06 [diff]
[WebView Support Lib] Tests: turn API level checks into feature checks.

Currently we guard feature tests with API level checks to avoid calling
features that are not supported under the current (device + WebView)
configuration.
These kinds of checks make it more cumbersome to do local testing since
you need to remove the checks to run the tests on older devices where
the support-library-glue path will be tested.

With this CL we turn the API level checks into feature-checks so that
whenever the tests are run on older devices with up-to-date WebView APKs
they will be testing the support-library-glue path.

Note that Presubmit won't exercise the support-library-glue path until
b/73454652 has been fixed (because we won't install
support-library-compatible WebView APKs on bots until that bug is
solved).

Bug: 38220211
Test: run androidx.webkit tests on an L device with an up-to-date
WebView APK.
Change-Id: I80ce18c55a8abd6565a8d0ff5297ef9c7b9f30be
3 files changed
tree: 689bb2e485005b8cd08a5a262d7f32e5746232a4
  1. .idea/
  2. annotations/
  3. api/
  4. app-toolkit/
  5. asynclayoutinflater/
  6. browser/
  7. buildSrc/
  8. car/
  9. cardview/
  10. collection/
  11. compat/
  12. content/
  13. coordinatorlayout/
  14. core/
  15. cursoradapter/
  16. customview/
  17. development/
  18. documentfile/
  19. drawerlayout/
  20. dynamic-animation/
  21. emoji/
  22. exifinterface/
  23. fragment/
  24. frameworks/
  25. gradle/
  26. graphics/
  27. gridlayout/
  28. heifwriter/
  29. interpolator/
  30. jetifier/
  31. leanback/
  32. leanback-preference/
  33. legacy/
  34. lifecycle/
  35. loader/
  36. localbroadcastmanager/
  37. media/
  38. media-widget/
  39. mediarouter/
  40. paging/
  41. palette/
  42. percent/
  43. persistence/
  44. preference/
  45. print/
  46. recommendation/
  47. recyclerview-selection/
  48. room/
  49. samples/
  50. scripts/
  51. slices/
  52. slidingpanelayout/
  53. swiperefreshlayout/
  54. testutils/
  55. testutils-ktx/
  56. textclassifier/
  57. transition/
  58. tv-provider/
  59. v7/
  60. viewpager/
  61. viewpager2/
  62. wear/
  63. webkit/
  64. webkit-codegen/
  65. .gitignore
  66. adding-support-library-as-included-build.md
  67. build.gradle
  68. gradle.properties
  69. gradlew
  70. include-composite-deps.gradle
  71. include-support-library.gradle
  72. LICENSE.txt
  73. OWNERS
  74. PREUPLOAD.cfg
  75. README.md
  76. settings.gradle
README.md

AOSP Support Library Contribution Guide

Accepted Types of Contributions

  • Bug fixes (needs a corresponding bug report in b.android.com)
  • Each bug fix is expected to come with tests
  • Fixing spelling errors
  • Updating documentation
  • Adding new tests to the area that is not currently covered by tests

We are not currently accepting new modules, features, or behavior changes.

Checking Out the Code

NOTE: You will need to use Linux or Mac OS. Building under Windows is not currently supported.

Follow the “Downloading the Source” guide to install and set up repo tool, but instead of running the listed repo commands to initialize the repository, run the folowing:

repo init -u https://android.googlesource.com/platform/manifest -b ub-supportlib-master

Now your repository is set to pull only what you need for building and running support library. Download the code (and grab a coffee while we pull down 7GB):

repo sync -j8 -c

You will use this command to sync your checkout in the future - it’s similar to git fetch

Using Android Studio

Open path/to/checkout/frameworks/support/ in Android Studio. Now you're ready edit, run, and test!

If you get “Unregistered VCS root detected” click “Add root” to enable git integration for Android Studio.

If you see any warnings (red underlines) run Build > Clean Project.

Builds

Full Build (Optional)

You can do most of your work from Android Studio, however you can also build the full support library from command line:

cd path/to/checkout/frameworks/support/
./gradlew createArchive

Building Support Library as part of your App build

If you intend to repeatedly make changes to Support Library and to wish to see the results in your app, and you don't want to have to repeatedly build them as separate Gradle projects, you can configure your app build to build Support Library too

Running Tests

Single Test Class or Method

  1. Open the desired test file in Android Studio.
  2. Right-click on a test class or @Test method name and select Run FooBarTest

Full Test Package

  1. In the project side panel open the desired module.
  2. Find the directory with the tests
  3. Right-click on the directory and select Run android.support.foobar

Running Sample Apps

Support library has a set of Android applications that exercise support library code. These applications can be useful when you want to debug a real running application, or reproduce a problem interactively, before writing test code.

These applications are named support-*-demos (e.g. support-4v-demos or support-leanback-demos. You can run them by clicking Run > Run ... and choosing the desired application.

Making a change

cd path/to/checkout/frameworks/support/
repo start my_branch_name .
(make needed modifications)
git commit -a
repo upload --current-branch .

If you see the following prompt, choose always:

Run hook scripts from https://android.googlesource.com/platform/manifest (yes/always/NO)?

Getting reviewed

  • After you run repo upload, open r.android.com
  • Sign in into your account (or create one if you do not have one yet)
  • Add an appropriate reviewer (use git log to find who did most modifications on the file you are fixing)