Gitiles
Code Review Sign In
review.blissroms.org / platform_frameworks_support / 63fb9955b209f1bb9d19e41df9784bfbdf63defe
commit63fb9955b209f1bb9d19e41df9784bfbdf63defe[log] [tgz]
authorMady Mellor <madym@google.com>Fri Mar 09 17:52:15 2018 -0800
committerMady Mellor <madym@google.com>Thu Mar 22 11:16:24 2018 -0700
tree506afbb775736d72fb3d8ce11efb3925ff63e0ce
parente7f1c6cf75ce36c633075445bd676572a9fe0f47 [diff]
Support “Updated 5 min. ago” for Slices with expired content

* SliceView controls indicating that updated text should be
  shown; if the content is expired we show the “Updated x time ago”
* Hidden API to turn this functionality on / off
* RowView renders it

Adds cases to render tests:
Custom toggle:
   - no subtitle => updated text shows in subtitle spot
Weather:
   - non-row as first item => no updated text
Ride:
   - small version has long summary => truncated subtitle
     with updated text
   - big version has shorts summary => full subtitle with
     update text

Test: ./gradlew slices-view:connectedCheck
Bug: 74338434
Change-Id: I5c61b3067d478979b01c0d492b97a35b758e5823
13 files changed
tree: 506afbb775736d72fb3d8ce11efb3925ff63e0ce
  1. .idea/
  2. annotations/
  3. api/
  4. app-toolkit/
  5. asynclayoutinflater/
  6. browser/
  7. buildSrc/
  8. car/
  9. cardview/
  10. collection/
  11. compat/
  12. content/
  13. coordinatorlayout/
  14. cursoradapter/
  15. customview/
  16. development/
  17. documentfile/
  18. drawerlayout/
  19. dynamic-animation/
  20. emoji/
  21. exifinterface/
  22. fragment/
  23. frameworks/
  24. gradle/
  25. graphics/
  26. gridlayout/
  27. heifwriter/
  28. interpolator/
  29. jetifier/
  30. leanback/
  31. leanback-preference/
  32. legacy/
  33. lifecycle/
  34. loader/
  35. localbroadcastmanager/
  36. media/
  37. mediarouter/
  38. paging/
  39. palette/
  40. percent/
  41. persistence/
  42. preference/
  43. print/
  44. recommendation/
  45. recyclerview-selection/
  46. room/
  47. samples/
  48. scripts/
  49. slices/
  50. slidingpanelayout/
  51. swiperefreshlayout/
  52. testutils/
  53. textclassifier/
  54. transition/
  55. tv-provider/
  56. v7/
  57. viewpager/
  58. viewpager2/
  59. wear/
  60. webkit/
  61. webkit-codegen/
  62. .gitignore
  63. adding-support-library-as-included-build.md
  64. Android.mk
  65. build.gradle
  66. CleanSpec.mk
  67. gradle.properties
  68. gradlew
  69. include-composite-deps.gradle
  70. include-support-library.gradle
  71. LICENSE.txt
  72. OWNERS
  73. PREUPLOAD.cfg
  74. README.md
  75. settings.gradle
README.md

AOSP Support Library Contribution Guide

Accepted Types of Contributions

  • Bug fixes (needs a corresponding bug report in b.android.com)
  • Each bug fix is expected to come with tests
  • Fixing spelling errors
  • Updating documentation
  • Adding new tests to the area that is not currently covered by tests

We are not currently accepting new modules, features, or behavior changes.

Checking Out the Code

NOTE: You will need to use Linux or Mac OS. Building under Windows is not currently supported.

Follow the “Downloading the Source” guide to install and set up repo tool, but instead of running the listed repo commands to initialize the repository, run the folowing:

repo init -u https://android.googlesource.com/platform/manifest -b ub-supportlib-master

Now your repository is set to pull only what you need for building and running support library. Download the code (and grab a coffee while we pull down 7GB):

repo sync -j8 -c

You will use this command to sync your checkout in the future - it’s similar to git fetch

Using Android Studio

Open path/to/checkout/frameworks/support/ in Android Studio. Now you're ready edit, run, and test!

If you get “Unregistered VCS root detected” click “Add root” to enable git integration for Android Studio.

If you see any warnings (red underlines) run Build > Clean Project.

Builds

Full Build (Optional)

You can do most of your work from Android Studio, however you can also build the full support library from command line:

cd path/to/checkout/frameworks/support/
./gradlew createArchive

Building Support Library as part of your App build

If you intend to repeatedly make changes to Support Library and to wish to see the results in your app, and you don't want to have to repeatedly build them as separate Gradle projects, you can configure your app build to build Support Library too

Running Tests

Single Test Class or Method

  1. Open the desired test file in Android Studio.
  2. Right-click on a test class or @Test method name and select Run FooBarTest

Full Test Package

  1. In the project side panel open the desired module.
  2. Find the directory with the tests
  3. Right-click on the directory and select Run android.support.foobar

Running Sample Apps

Support library has a set of Android applications that exercise support library code. These applications can be useful when you want to debug a real running application, or reproduce a problem interactively, before writing test code.

These applications are named support-*-demos (e.g. support-4v-demos or support-leanback-demos. You can run them by clicking Run > Run ... and choosing the desired application.

Making a change

cd path/to/checkout/frameworks/support/
repo start my_branch_name .
(make needed modifications)
git commit -a
repo upload --current-branch .

If you see the following prompt, choose always:

Run hook scripts from https://android.googlesource.com/platform/manifest (yes/always/NO)?

Getting reviewed

  • After you run repo upload, open r.android.com
  • Sign in into your account (or create one if you do not have one yet)
  • Add an appropriate reviewer (use git log to find who did most modifications on the file you are fixing)