Gitiles
Code Review Sign In
review.blissroms.org / platform_frameworks_support / 36545bb3f2b12af352e550c278cff9026a18ca54
commit36545bb3f2b12af352e550c278cff9026a18ca54[log] [tgz]
authorSean Kelley <smskelley@google.com>Tue Apr 04 15:06:53 2017 -0700
committerSean Kelley <smskelley@google.com>Thu May 04 13:27:31 2017 -0700
treec36d0fcdaaf4931b9ed426160989292bd87390de
parent7fdc07b47738042cc50d43164f9b110bf8cd9db5 [diff]
Initial commit of Wearable Drawers

This CL brings a snapshot of the wearable drawers to gerrit. The drawers
depend upon several other classes in Wearable Support, so those were
brought over as well, but marked @hide. They should be able to be deleted
when there's a suitable alternative to CircledImageView.

The publicly accessible classes added by this change are:
 - WearableDrawerLayout
 - WearableDrawerView
 - WearableNavigationDrawerView
 - WearableActionDrawerView
 - WearableDrawerController

Their current public documentation can be found here:
https://developer.android.com/wear/preview/features/ui-nav-actions.html

The API changes made were:
  - The package changed from android.support.wearable.view.drawer to
    android.support.wear.widget.drawer.
  - WearableDrawerLayout:
    - DrawerState annotation was changed to SOURCE retained
    - DrawerStateCallback:
      - Now passes WearableDrawerlayout as first param to all methods.
      - Is now concrete with empty methods.
    - openDrawer(), closeDrawer(), and peekDrawer() are package private.
  - WearableActionDrawerView:
    - Renamed from WearableActionDrawer to WearableActionDrawerView
    - OnMenuItemClickListener was swapped out for MenuItem's.
  - WearableNavigationDrawerView:
    - Renamed from WearableNavigationDrawer to WearableNavigationDrawerView
    - Default navigationStyle is now SINGLE_PAGE
    - Added getNavigationStyle()
    - WearableNavigationDrawerViewAdapter:
      - onItemSelected was removed and moved into a standalone
        OnItemSelected listener.
    - Added (add|remove)OnItemSelectedListener(listener)
  - WearableDrawerView:
    - boolean hasDrawerContent() was removed.
    - openDrawer(), closeDrawer(), and peekDrawer() have been removed.
    - WearableDrawerController getController() has been added.
    - setShouldOnlyOpenWhenAtTop --> setOpenOnlyAtTopEnabled
    - shouldOnlyOpenWhenAtTop --> isOpenOnlyAtTopEnabled
    - setShouldPeekOnScrollDown --> setPeekOnScrollDownEnabled
    - shouldPeekOnScrollDown --> isPeekOnScrollDownEnabled
    - setShouldLockWhenNotOpenOrPeeking --> setLockedWhenClosed
    - shouldLockWhenNotOpenOrPeeking --> isLockedWhenClosed
    - canAutoPeek --> isAutoPeekEnabled
    - setCanAutoPeek --> setIsAutoPeekEnabled
    - lockDrawerClosed removed
    - lockDrawerOpened removed
    - unlockDrawer removed
    - setIsLocked(boolean) added
    - Uses Widget.Wearable.WearableDrawerView style to specify default
      background and elevation.
  - Misc:
    - All custom attributes are now camelCase.
    - All APIs that took a View that was expected to be a drawer now
      take in a WearableDrawerView.
    - Some instances of String being used in the API were migrated to
      CharSequence.
    - All Views now have a 4 arg constructor.

Test: Manually and Espresso tests

Bug: 37417930
Bug: 37419365
Change-Id: Iec1843cccf80efe3d7c5b3db2274ec41f914c83d
66 files changed
tree: c36d0fcdaaf4931b9ed426160989292bd87390de
  1. .idea/
  2. annotations/
  3. api/
  4. buildSrc/
  5. compat/
  6. core-ui/
  7. core-utils/
  8. customtabs/
  9. design/
  10. development/
  11. dynamic-animation/
  12. emoji/
  13. exifinterface/
  14. fragment/
  15. frameworks/
  16. gradle/
  17. graphics/
  18. media-compat/
  19. percent/
  20. recommendation/
  21. samples/
  22. scripts/
  23. testutils/
  24. transition/
  25. tv-provider/
  26. v13/
  27. v14/
  28. v17/
  29. v4/
  30. v7/
  31. wear/
  32. .gitignore
  33. Android.mk
  34. build.gradle
  35. CleanSpec.mk
  36. droiddoc.mk
  37. gradle.properties
  38. gradlew
  39. pathmap.mk
  40. PREUPLOAD.cfg
  41. README.md
  42. settings.gradle
README.md

AOSP Support Library Contribution Guide

Accepted Types of Contributions

  • Bug fixes (needs a corresponding bug report in b.android.com)
  • Each bug fix is expected to come with tests
  • Fixing spelling errors
  • Updating documentation
  • Adding new tests to the area that is not currently covered by tests

We are not currently accepting new modules, features, or behavior changes.

Checking Out the Code

NOTE: You will need to use Linux or Mac OS. Building under Windows is not currently supported.

Follow the “Downloading the Source” guide to install and set up repo tool, but instead of running the listed repo commands to initialize the repository, run the folowing:

repo init -u https://android.googlesource.com/platform/manifest -b ub-supportlib-master

Now your repository is set to pull only what you need for building and running support library. Download the code (and grab a coffee while we pull down 7GB):

repo sync -j8 -c

You will use this command to sync your checkout in the future - it’s similar to git fetch

Using Android Studio

Open path/to/checkout/frameworks/support/ in Android Studio. Now you're ready edit, run, and test!

If you get “Unregistered VCS root detected” click “Add root” to enable git integration for Android Studio.

If you see any warnings (red underlines) run Build > Clean Project.

Optional - Full Build

You can do most of your work from Android Studio, however you can also build the full support library from command line:

cd path/to/checkout/frameworks/support/
./gradlew createArchive

Running Tests

Single Test Class or Method

  1. Open the desired test file in Android Studio.
  2. Right-click on a test class or @Test method name and select Run FooBarTest

Full Test Package

  1. In the project side panel open the desired module.
  2. Find the directory with the tests
  3. Right-click on the directory and select Run android.support.foobar

Running Sample Apps

Support library has a set of Android applications that exercise support library code. These applications can be useful when you want to debug a real running application, or reproduce a problem interactively, before writing test code.

These applications are named support-*-demos (e.g. support-4v-demos or support-leanback-demos. You can run them by clicking Run > Run ... and choosing the desired application.

Making a change

cd path/to/checkout/frameworks/support/
repo start my_branch_name .
(make needed modifications)
git commit -a
repo upload --current-branch .

If you see the following prompt, choose always:

Run hook scripts from https://android.googlesource.com/platform/manifest (yes/always/NO)?

Getting reviewed

  • After you run repo upload, open r.android.com
  • Sign in into your account (or create one if you do not have one yet)
  • Add an appropriate reviewer (use git log to find who did most modifications on the file you are fixing)