Gitiles
Code Review Sign In
review.blissroms.org / platform_frameworks_support / 346a12bcba3c4b5ea96758f104a1df257e479e6d
commit346a12bcba3c4b5ea96758f104a1df257e479e6d[log] [tgz]
authorEvan Rosky <erosky@google.com>Fri Mar 10 16:03:17 2017 -0800
committerEvan Rosky <erosky@google.com>Fri Mar 31 21:22:26 2017 +0000
tree051e976bc5e271e75bf1a3387161a751b3a98cf8
parent4f0417b0590700424810c2cc7ba947207720b918 [diff]
Don't consume unhandled shortcuts in ToolbarActionBar

ToolbarActionBar was consuming all shortcuts preventing
system shortcuts (like shift+tab) from working.

This was done to prevent unnecessary preparing of phone-window
menus/panels. ToolbarActionBar's callback-wrapper now returns
a dummy View to onCreatePanelView which has the same effect
without having to consume shortcuts.

Bug: 32482282
Bug: 18021345
Test: KeyboardShortcutsTestCaseWithToolbar#testKeyShortcuts

Change-Id: I971ac0f741d26bea4a2e92e2d2ebc22046ba6317
3 files changed
tree: 051e976bc5e271e75bf1a3387161a751b3a98cf8
  1. .idea/
  2. annotations/
  3. api/
  4. buildSrc/
  5. compat/
  6. core-ui/
  7. core-utils/
  8. customtabs/
  9. design/
  10. development/
  11. dynamic-animation/
  12. emoji/
  13. exifinterface/
  14. fragment/
  15. frameworks/
  16. gradle/
  17. graphics/
  18. instantvideo/
  19. media-compat/
  20. percent/
  21. recommendation/
  22. samples/
  23. scripts/
  24. testutils/
  25. transition/
  26. tv-provider/
  27. v13/
  28. v14/
  29. v17/
  30. v4/
  31. v7/
  32. wearable/
  33. .gitignore
  34. Android.mk
  35. build.gradle
  36. CleanSpec.mk
  37. droiddoc.mk
  38. gradle.properties
  39. gradlew
  40. pathmap.mk
  41. PREUPLOAD.cfg
  42. README.md
  43. settings.gradle
README.md

AOSP Support Library Contribution Guide

Accepted Types of Contributions

  • Bug fixes (needs a corresponding bug report in b.android.com)
  • Each bug fix is expected to come with tests
  • Fixing spelling errors
  • Updating documentation
  • Adding new tests to the area that is not currently covered by tests

We are not currently accepting new modules, features, or behavior changes.

Checking Out the Code

NOTE: You will need to use Linux or Mac OS. Building under Windows is not currently supported.

Follow the “Downloading the Source” guide to install and set up repo tool, but instead of running the listed repo commands to initialize the repository, run the folowing:

repo init -u https://android.googlesource.com/platform/manifest -b ub-supportlib-master

Now your repository is set to pull only what you need for building and running support library. Download the code (and grab a coffee while we pull down 7GB):

repo sync -j8 -c

You will use this command to sync your checkout in the future - it’s similar to git fetch

Using Android Studio

Open path/to/checkout/frameworks/support/ in Android Studio. Now you're ready edit, run, and test!

If you get “Unregistered VCS root detected” click “Add root” to enable git integration for Android Studio.

If you see any warnings (red underlines) run Build > Clean Project.

Optional - Full Build

You can do most of your work from Android Studio, however you can also build the full support library from command line:

cd path/to/checkout/frameworks/support/
./gradlew createArchive

Running Tests

Single Test Class or Method

  1. Open the desired test file in Android Studio.
  2. Right-click on a test class or @Test method name and select Run FooBarTest

Full Test Package

  1. In the project side panel open the desired module.
  2. Find the directory with the tests
  3. Right-click on the directory and select Run android.support.foobar

Running Sample Apps

Support library has a set of Android applications that exercise support library code. These applications can be useful when you want to debug a real running application, or reproduce a problem interactively, before writing test code.

These applications are named support-*-demos (e.g. support-4v-demos or support-leanback-demos. You can run them by clicking Run > Run ... and choosing the desired application.

Making a change

cd path/to/checkout/frameworks/support/
repo start my_branch_name .
(make needed modifications)
git commit -a
repo upload --current-branch .

If you see the following prompt, choose always:

Run hook scripts from https://android.googlesource.com/platform/manifest (yes/always/NO)?

Getting reviewed

  • After you run repo upload, open r.android.com
  • Sign in into your account (or create one if you do not have one yet)
  • Add an appropriate reviewer (use git log to find who did most modifications on the file you are fixing)