Gitiles
Code Review Sign In
review.blissroms.org / platform_frameworks_support / 5843a353d7d4740a2d6119fdd90f258f645f4f20
commit5843a353d7d4740a2d6119fdd90f258f645f4f20[log] [tgz]
authorYuichi Araki <yaraki@google.com>Thu Jul 13 08:58:05 2017 +0900
committerYuichi Araki <yaraki@google.com>Fri Jul 21 18:14:02 2017 +0900
tree0236bccfe19410f4745e0253131233366f928739
parent2fab9e128aaed2c4139657748dd92e23dc10cb02 [diff]
Fix InvalidationTracker for custom database

InvalidationTracker queries the database when something changes, but
this can cause exception when the database is closed during the query is
being run. We prevent this by catching the exception, but that's not
enough for custom database implementation as it might throw some types
of exception we don't know about.

This CL introduces a close lock between RoomDatabase and
InvalidationTracker. As far as the database is closed with
RoomDatabase.close(), InvalidationTracker can tell that it is being
closed and stop querying it.

We still need to catch IllegalStateException and SQLiteException because
some tests have to close the underlying SupportSQLiteDatabase bypassing
RoomDatabase and currently there's no way InvalidationTracker can hook
into it.

Bug: 63162311
Test: CustomDatbaseTest
Change-Id: Iece7f95eac886287ea09d69ed44cba786340872b
5 files changed
tree: 0236bccfe19410f4745e0253131233366f928739
  1. .idea/
  2. annotations/
  3. api/
  4. app-toolkit/
  5. buildSrc/
  6. compat/
  7. core-ui/
  8. core-utils/
  9. customtabs/
  10. design/
  11. development/
  12. dynamic-animation/
  13. emoji/
  14. exifinterface/
  15. fragment/
  16. frameworks/
  17. gradle/
  18. graphics/
  19. lifecycle/
  20. media-compat/
  21. paging/
  22. percent/
  23. recommendation/
  24. room/
  25. samples/
  26. samples-flatfoot/
  27. scripts/
  28. testutils/
  29. transition/
  30. tv-provider/
  31. v13/
  32. v14/
  33. v17/
  34. v4/
  35. v7/
  36. wear/
  37. .gitignore
  38. Android.mk
  39. build.gradle
  40. CleanSpec.mk
  41. droiddoc.mk
  42. gradle.properties
  43. gradlew
  44. LICENSE.txt
  45. makeFlatfootRepo.sh
  46. pathmap.mk
  47. PREUPLOAD.cfg
  48. README.md
  49. settings.gradle
README.md

AOSP Support Library Contribution Guide

Accepted Types of Contributions

  • Bug fixes (needs a corresponding bug report in b.android.com)
  • Each bug fix is expected to come with tests
  • Fixing spelling errors
  • Updating documentation
  • Adding new tests to the area that is not currently covered by tests

We are not currently accepting new modules, features, or behavior changes.

Checking Out the Code

NOTE: You will need to use Linux or Mac OS. Building under Windows is not currently supported.

Follow the “Downloading the Source” guide to install and set up repo tool, but instead of running the listed repo commands to initialize the repository, run the folowing:

repo init -u https://android.googlesource.com/platform/manifest -b ub-supportlib-master

Now your repository is set to pull only what you need for building and running support library. Download the code (and grab a coffee while we pull down 7GB):

repo sync -j8 -c

You will use this command to sync your checkout in the future - it’s similar to git fetch

Using Android Studio

Open path/to/checkout/frameworks/support/ in Android Studio. Now you're ready edit, run, and test!

If you get “Unregistered VCS root detected” click “Add root” to enable git integration for Android Studio.

If you see any warnings (red underlines) run Build > Clean Project.

Optional - Full Build

You can do most of your work from Android Studio, however you can also build the full support library from command line:

cd path/to/checkout/frameworks/support/
./gradlew createArchive

Running Tests

Single Test Class or Method

  1. Open the desired test file in Android Studio.
  2. Right-click on a test class or @Test method name and select Run FooBarTest

Full Test Package

  1. In the project side panel open the desired module.
  2. Find the directory with the tests
  3. Right-click on the directory and select Run android.support.foobar

Running Sample Apps

Support library has a set of Android applications that exercise support library code. These applications can be useful when you want to debug a real running application, or reproduce a problem interactively, before writing test code.

These applications are named support-*-demos (e.g. support-4v-demos or support-leanback-demos. You can run them by clicking Run > Run ... and choosing the desired application.

Making a change

cd path/to/checkout/frameworks/support/
repo start my_branch_name .
(make needed modifications)
git commit -a
repo upload --current-branch .

If you see the following prompt, choose always:

Run hook scripts from https://android.googlesource.com/platform/manifest (yes/always/NO)?

Getting reviewed

  • After you run repo upload, open r.android.com
  • Sign in into your account (or create one if you do not have one yet)
  • Add an appropriate reviewer (use git log to find who did most modifications on the file you are fixing)