| commit | 89ded73522265e09a03fd04f4ffccef7118bdedb | [log] [tgz] |
|---|---|---|
| author | Dake Gu <dake@google.com> | Fri Sep 22 11:28:56 2017 -0700 |
| committer | Dake Gu <dake@google.com> | Mon Sep 25 22:04:58 2017 +0000 |
| tree | 01e2b4e184428ce249934ef630c84cae9261ba75 | |
| parent | 56cb0cc2547d28ac5b593d314641ab07a94480d9 [diff] |
leanback: fix flaky testScrollAndRemove In short: Skips the minScroll/maxScroll check in layout pass because onLayoutChildren() might call scrollDirectionPrimary() to compensate remaining scroll distance. In long explaination: onLayoutChildren() will compensate remaining scroll distance. Let's say when onLayoutChildren() is called, the RecyclerView is still scrolling toward left, there are remaining 100 pixels. onLayoutChildren() after aligns focused child, it calls scrollDirectionPrimary() to move all children 100 pixels toward right, so after onLayoutChildren(), scroll animation would continue moving toward left for 100 pixels and stops at a perfectly aligned state. When onLayoutChildren() compensates the 100 pixels, the delta may violate the minScroll in scrollDirectionPrimary(), we should ignore the limit cap in layout pass. The CL also includes a fix in WindowAlignment.updateMinMax() which was hidden by the extra delta cap check in GridLayoutManager. Bug: 64931938 Test: testScrollAndRemoveSample1 testScrollAndRemove testPreferKeyLine1 testPreferKeyLine2 testPreferKeyLine10000 Change-Id: Ieaa0b9f39fae0494f0fa779cf2647721eb388896
We are not currently accepting new modules, features, or behavior changes.
NOTE: You will need to use Linux or Mac OS. Building under Windows is not currently supported.
Follow the “Downloading the Source” guide to install and set up repo tool, but instead of running the listed repo commands to initialize the repository, run the folowing:
repo init -u https://android.googlesource.com/platform/manifest -b ub-supportlib-master
Now your repository is set to pull only what you need for building and running support library. Download the code (and grab a coffee while we pull down 7GB):
repo sync -j8 -c
You will use this command to sync your checkout in the future - it’s similar to git fetch
Open path/to/checkout/frameworks/support/ in Android Studio. Now you're ready edit, run, and test!
If you get “Unregistered VCS root detected” click “Add root” to enable git integration for Android Studio.
If you see any warnings (red underlines) run Build > Clean Project.
You can do most of your work from Android Studio, however you can also build the full support library from command line:
cd path/to/checkout/frameworks/support/ ./gradlew createArchive
Run FooBarTestRun android.support.foobarSupport library has a set of Android applications that exercise support library code. These applications can be useful when you want to debug a real running application, or reproduce a problem interactively, before writing test code.
These applications are named support-*-demos (e.g. support-4v-demos or support-leanback-demos. You can run them by clicking Run > Run ... and choosing the desired application.
cd path/to/checkout/frameworks/support/ repo start my_branch_name . (make needed modifications) git commit -a repo upload --current-branch .
If you see the following prompt, choose always:
Run hook scripts from https://android.googlesource.com/platform/manifest (yes/always/NO)?