Gitiles
Code Review Sign In
review.blissroms.org / platform_frameworks_support / 12e03825887438734f86bb11cafe4939cc645236
commit12e03825887438734f86bb11cafe4939cc645236[log] [tgz]
authorGeorge Mount <mount@google.com>Fri Mar 23 15:35:21 2018 -0700
committerYuichi Araki <yaraki@google.com>Fri Apr 13 06:47:42 2018 +0000
tree4072f3db0e6ce2a32e342aed6c0a592649f94e3f
parent8dc3cb42a4009bf1f5a702c8b42954e97e8131ef [diff]
Avoid improperly removing views during transitions

Bug: 65715616

There are two places where views were being removed improperly
during transitions. The first was when making a copy of a view.
Because of hardware bitmaps, views were being moved to the overlay
so that the image could be copied. This CL moves the view back
into its parent after copying the image.

The second location is where the view was being considered an
overlay. When a view is in the starting scene and the view in
the end scene cannot be used, the starting scene view was being
moved to the overlay. This is only valid when the view is alowed
to be removed. Instead, a bitmap copy of the view is moved to
the overlay.

Test: new FadeTest
Framework change: Ieb32b146cf65e3ff4ed6d7bb8325e74763dbd2d5
Change-Id: I99a7248bfd8a18ae922b4351bf79e2ff2e51a319
(cherry picked from commit bd9b57071447a2ae2c42514b067022b68ea1c347)
5 files changed
tree: 4072f3db0e6ce2a32e342aed6c0a592649f94e3f
  1. .idea/
  2. annotations/
  3. api/
  4. app-toolkit/
  5. asynclayoutinflater/
  6. browser/
  7. buildSrc/
  8. car/
  9. cardview/
  10. collection/
  11. compat/
  12. content/
  13. coordinatorlayout/
  14. cursoradapter/
  15. customview/
  16. development/
  17. documentfile/
  18. drawerlayout/
  19. dynamic-animation/
  20. emoji/
  21. exifinterface/
  22. fragment/
  23. frameworks/
  24. gradle/
  25. graphics/
  26. gridlayout/
  27. heifwriter/
  28. interpolator/
  29. jetifier/
  30. leanback/
  31. leanback-preference/
  32. legacy/
  33. lifecycle/
  34. loader/
  35. localbroadcastmanager/
  36. media/
  37. media-widget/
  38. mediarouter/
  39. paging/
  40. palette/
  41. percent/
  42. persistence/
  43. preference/
  44. print/
  45. recommendation/
  46. recyclerview-selection/
  47. room/
  48. samples/
  49. scripts/
  50. slices/
  51. slidingpanelayout/
  52. swiperefreshlayout/
  53. testutils/
  54. textclassifier/
  55. transition/
  56. tv-provider/
  57. v7/
  58. viewpager/
  59. viewpager2/
  60. wear/
  61. webkit/
  62. webkit-codegen/
  63. .gitignore
  64. adding-support-library-as-included-build.md
  65. build.gradle
  66. gradle.properties
  67. gradlew
  68. include-composite-deps.gradle
  69. include-support-library.gradle
  70. LICENSE.txt
  71. OWNERS
  72. PREUPLOAD.cfg
  73. README.md
  74. settings.gradle
README.md

AOSP Support Library Contribution Guide

Accepted Types of Contributions

  • Bug fixes (needs a corresponding bug report in b.android.com)
  • Each bug fix is expected to come with tests
  • Fixing spelling errors
  • Updating documentation
  • Adding new tests to the area that is not currently covered by tests

We are not currently accepting new modules, features, or behavior changes.

Checking Out the Code

NOTE: You will need to use Linux or Mac OS. Building under Windows is not currently supported.

Follow the “Downloading the Source” guide to install and set up repo tool, but instead of running the listed repo commands to initialize the repository, run the folowing:

repo init -u https://android.googlesource.com/platform/manifest -b ub-supportlib-master

Now your repository is set to pull only what you need for building and running support library. Download the code (and grab a coffee while we pull down 7GB):

repo sync -j8 -c

You will use this command to sync your checkout in the future - it’s similar to git fetch

Using Android Studio

Open path/to/checkout/frameworks/support/ in Android Studio. Now you're ready edit, run, and test!

If you get “Unregistered VCS root detected” click “Add root” to enable git integration for Android Studio.

If you see any warnings (red underlines) run Build > Clean Project.

Builds

Full Build (Optional)

You can do most of your work from Android Studio, however you can also build the full support library from command line:

cd path/to/checkout/frameworks/support/
./gradlew createArchive

Building Support Library as part of your App build

If you intend to repeatedly make changes to Support Library and to wish to see the results in your app, and you don't want to have to repeatedly build them as separate Gradle projects, you can configure your app build to build Support Library too

Running Tests

Single Test Class or Method

  1. Open the desired test file in Android Studio.
  2. Right-click on a test class or @Test method name and select Run FooBarTest

Full Test Package

  1. In the project side panel open the desired module.
  2. Find the directory with the tests
  3. Right-click on the directory and select Run android.support.foobar

Running Sample Apps

Support library has a set of Android applications that exercise support library code. These applications can be useful when you want to debug a real running application, or reproduce a problem interactively, before writing test code.

These applications are named support-*-demos (e.g. support-4v-demos or support-leanback-demos. You can run them by clicking Run > Run ... and choosing the desired application.

Making a change

cd path/to/checkout/frameworks/support/
repo start my_branch_name .
(make needed modifications)
git commit -a
repo upload --current-branch .

If you see the following prompt, choose always:

Run hook scripts from https://android.googlesource.com/platform/manifest (yes/always/NO)?

Getting reviewed

  • After you run repo upload, open r.android.com
  • Sign in into your account (or create one if you do not have one yet)
  • Add an appropriate reviewer (use git log to find who did most modifications on the file you are fixing)