Gitiles
Code Review Sign In
review.blissroms.org / platform_frameworks_support / acd97abbd4fdbafc654a781bdeecccad2945c15a
commitacd97abbd4fdbafc654a781bdeecccad2945c15a[log] [tgz]
authorDake Gu <dake@google.com>Wed Oct 04 16:41:17 2017 -0700
committerDake Gu <dake@google.com>Wed Oct 04 16:49:00 2017 -0700
treefeb3ef3c0785c0900be954c995becf3be445eac8
parentbd7f9492bed4ef7d8457bf0270972bffee276c84 [diff]
leanback: fix the requestAudioFocus nightmare

In b/17851959, Search fragment was made to requestAudioFocus
to duck background music. Then later further change is made to
stop listening when lose focus. This causes recognition aborted when
GSA for TV 3.0 starts to duck the music too.

The original bug really should be fixed in GSA since we should only
have one entity to requestAudioFocus. This CL will cause
a regression of audio not ducking on devices not yet updated
to GSA 3.0 but it should be resolved soon and app will take time
to recompile with not yet released support lib.

Test: manually tested sample app
Bug: 17851959
Bug: 67119344

Change-Id: I86a087e5a99b141fb14c1626c822fdefd667899a
1 file changed
tree: feb3ef3c0785c0900be954c995becf3be445eac8
  1. .idea/
  2. annotations/
  3. api/
  4. app-toolkit/
  5. buildSrc/
  6. compat/
  7. content/
  8. core-ui/
  9. core-utils/
  10. customtabs/
  11. design/
  12. development/
  13. dynamic-animation/
  14. emoji/
  15. exifinterface/
  16. fragment/
  17. frameworks/
  18. gradle/
  19. graphics/
  20. lifecycle/
  21. media-compat/
  22. media-compat-test-client/
  23. media-compat-test-lib/
  24. media-compat-test-service/
  25. paging/
  26. percent/
  27. persistence/
  28. recommendation/
  29. room/
  30. samples/
  31. scripts/
  32. testutils/
  33. transition/
  34. tv-provider/
  35. v13/
  36. v14/
  37. v17/
  38. v4/
  39. v7/
  40. wear/
  41. .gitignore
  42. Android.mk
  43. build.gradle
  44. CleanSpec.mk
  45. gradle.properties
  46. gradlew
  47. LICENSE.txt
  48. makeFlatfootRepo.sh
  49. pathmap.mk
  50. PREUPLOAD.cfg
  51. README.md
  52. settings.gradle
README.md

AOSP Support Library Contribution Guide

Accepted Types of Contributions

  • Bug fixes (needs a corresponding bug report in b.android.com)
  • Each bug fix is expected to come with tests
  • Fixing spelling errors
  • Updating documentation
  • Adding new tests to the area that is not currently covered by tests

We are not currently accepting new modules, features, or behavior changes.

Checking Out the Code

NOTE: You will need to use Linux or Mac OS. Building under Windows is not currently supported.

Follow the “Downloading the Source” guide to install and set up repo tool, but instead of running the listed repo commands to initialize the repository, run the folowing:

repo init -u https://android.googlesource.com/platform/manifest -b ub-supportlib-master

Now your repository is set to pull only what you need for building and running support library. Download the code (and grab a coffee while we pull down 7GB):

repo sync -j8 -c

You will use this command to sync your checkout in the future - it’s similar to git fetch

Using Android Studio

Open path/to/checkout/frameworks/support/ in Android Studio. Now you're ready edit, run, and test!

If you get “Unregistered VCS root detected” click “Add root” to enable git integration for Android Studio.

If you see any warnings (red underlines) run Build > Clean Project.

Optional - Full Build

You can do most of your work from Android Studio, however you can also build the full support library from command line:

cd path/to/checkout/frameworks/support/
./gradlew createArchive

Running Tests

Single Test Class or Method

  1. Open the desired test file in Android Studio.
  2. Right-click on a test class or @Test method name and select Run FooBarTest

Full Test Package

  1. In the project side panel open the desired module.
  2. Find the directory with the tests
  3. Right-click on the directory and select Run android.support.foobar

Running Sample Apps

Support library has a set of Android applications that exercise support library code. These applications can be useful when you want to debug a real running application, or reproduce a problem interactively, before writing test code.

These applications are named support-*-demos (e.g. support-4v-demos or support-leanback-demos. You can run them by clicking Run > Run ... and choosing the desired application.

Making a change

cd path/to/checkout/frameworks/support/
repo start my_branch_name .
(make needed modifications)
git commit -a
repo upload --current-branch .

If you see the following prompt, choose always:

Run hook scripts from https://android.googlesource.com/platform/manifest (yes/always/NO)?

Getting reviewed

  • After you run repo upload, open r.android.com
  • Sign in into your account (or create one if you do not have one yet)
  • Add an appropriate reviewer (use git log to find who did most modifications on the file you are fixing)