Gitiles
Code Review Sign In
review.blissroms.org / platform_frameworks_support / b794b5b0f4bcd000e098265a6ec63d4b0cf3852f
commitb794b5b0f4bcd000e098265a6ec63d4b0cf3852f[log] [tgz]
authorMady Mellor <madym@google.com>Wed Feb 07 11:06:48 2018 -0800
committerMady Mellor <madym@google.com>Thu Feb 15 16:36:09 2018 -0800
treef739148b25f6517c0a106a4d32e20bbe7e591847
parentaf76b3bd62a6b218bb44917b1dddfa1ee4803149 [diff]
Add ability to manipulate the actions shown on a slice

* Adds helper method to get a list of the slice actions from a Slice
* Adds methods on SliceView allowing modification of the displayed actions
* If the action row isn’t showing, the actions will be displayed in
  the header of the slice, otherwise they’ll display in the action row
* If there aren’t enough actions to display in the action row, they’ll
  be displayed in the header instead
* If the slice doesn’t have a header, and the first row has a toggle,
  and there are actions, the actions will only be displayed if the action
  row is allowed
* Updates samples to use ListBuilder#setActions
* Adds flag to test action row in SliceBrowser

Does not consider priority when display actions; will come in follow up

Test: manual
Bug: 69472451
Change-Id: I1a976830ed89a8a475355a51a3f2b18b1c49027f
11 files changed
tree: f739148b25f6517c0a106a4d32e20bbe7e591847
  1. .idea/
  2. annotations/
  3. api/
  4. app-toolkit/
  5. buildSrc/
  6. car/
  7. compat/
  8. content/
  9. core-ui/
  10. core-utils/
  11. customtabs/
  12. design/
  13. development/
  14. dynamic-animation/
  15. emoji/
  16. exifinterface/
  17. fragment/
  18. frameworks/
  19. gradle/
  20. graphics/
  21. jetifier/
  22. leanback/
  23. lifecycle/
  24. media-compat/
  25. paging/
  26. percent/
  27. persistence/
  28. preference-leanback/
  29. recommendation/
  30. recyclerview-selection/
  31. room/
  32. samples/
  33. scripts/
  34. slices/
  35. testutils/
  36. textclassifier/
  37. transition/
  38. tv-provider/
  39. v13/
  40. v14/
  41. v4/
  42. v7/
  43. viewpager2/
  44. wear/
  45. webkit/
  46. webkit-codegen/
  47. .gitignore
  48. adding-support-library-as-included-build.md
  49. Android.mk
  50. build.gradle
  51. CleanSpec.mk
  52. gradle.properties
  53. gradlew
  54. include-composite-deps.gradle
  55. include-support-library.gradle
  56. LICENSE.txt
  57. makeFlatfootRepo.sh
  58. OWNERS
  59. pathmap.mk
  60. PREUPLOAD.cfg
  61. README.md
  62. settings.gradle
README.md

AOSP Support Library Contribution Guide

Accepted Types of Contributions

  • Bug fixes (needs a corresponding bug report in b.android.com)
  • Each bug fix is expected to come with tests
  • Fixing spelling errors
  • Updating documentation
  • Adding new tests to the area that is not currently covered by tests

We are not currently accepting new modules, features, or behavior changes.

Checking Out the Code

NOTE: You will need to use Linux or Mac OS. Building under Windows is not currently supported.

Follow the “Downloading the Source” guide to install and set up repo tool, but instead of running the listed repo commands to initialize the repository, run the folowing:

repo init -u https://android.googlesource.com/platform/manifest -b ub-supportlib-master

Now your repository is set to pull only what you need for building and running support library. Download the code (and grab a coffee while we pull down 7GB):

repo sync -j8 -c

You will use this command to sync your checkout in the future - it’s similar to git fetch

Using Android Studio

Open path/to/checkout/frameworks/support/ in Android Studio. Now you're ready edit, run, and test!

If you get “Unregistered VCS root detected” click “Add root” to enable git integration for Android Studio.

If you see any warnings (red underlines) run Build > Clean Project.

Builds

Full Build (Optional)

You can do most of your work from Android Studio, however you can also build the full support library from command line:

cd path/to/checkout/frameworks/support/
./gradlew createArchive

Building Support Library as part of your App build

If you intend to repeatedly make changes to Support Library and to wish to see the results in your app, and you don't want to have to repeatedly build them as separate Gradle projects, you can configure your app build to build Support Library too

Running Tests

Single Test Class or Method

  1. Open the desired test file in Android Studio.
  2. Right-click on a test class or @Test method name and select Run FooBarTest

Full Test Package

  1. In the project side panel open the desired module.
  2. Find the directory with the tests
  3. Right-click on the directory and select Run android.support.foobar

Running Sample Apps

Support library has a set of Android applications that exercise support library code. These applications can be useful when you want to debug a real running application, or reproduce a problem interactively, before writing test code.

These applications are named support-*-demos (e.g. support-4v-demos or support-leanback-demos. You can run them by clicking Run > Run ... and choosing the desired application.

Making a change

cd path/to/checkout/frameworks/support/
repo start my_branch_name .
(make needed modifications)
git commit -a
repo upload --current-branch .

If you see the following prompt, choose always:

Run hook scripts from https://android.googlesource.com/platform/manifest (yes/always/NO)?

Getting reviewed

  • After you run repo upload, open r.android.com
  • Sign in into your account (or create one if you do not have one yet)
  • Add an appropriate reviewer (use git log to find who did most modifications on the file you are fixing)