Gitiles
Code Review Sign In
review.blissroms.org / platform_frameworks_support / b8f55949fd238a9758ebd37d0521914b2bed8a25
commitb8f55949fd238a9758ebd37d0521914b2bed8a25[log] [tgz]
authorDianne Hackborn <hackbod@google.com>Wed Aug 16 17:29:28 2017 -0700
committerChristopher Tate <ctate@google.com>Mon Aug 28 11:16:39 2017 -0700
tree7cd9d52145e854ff14a465ba59248990a7f42ad7
parent0227b52552063479177769d84af4258e3740522b [diff]
Rework wake lock handling of JobIntentService

Now instead of holding a wake lock the entire time the
service is running, we only hold it while processing work.
Also have a 10 minute timeout for how long we are allowed
to continually hold it, matching JobScheduler semantics (kind-of).

Bug: 62507719
Test: ./gradlew support-compat:connectedCheck --info --daemon -Pandroid.testInstrumentationRunnerArguments.class=android.support.v4.app.JobIntentServiceTest

Change-Id: If36d04dae396b75919eea47e15a26b2ed883a507
1 file changed
tree: 7cd9d52145e854ff14a465ba59248990a7f42ad7
  1. .idea/
  2. annotations/
  3. api/
  4. app-toolkit/
  5. buildSrc/
  6. compat/
  7. core-ui/
  8. core-utils/
  9. customtabs/
  10. design/
  11. development/
  12. dynamic-animation/
  13. emoji/
  14. exifinterface/
  15. fragment/
  16. frameworks/
  17. gradle/
  18. graphics/
  19. lifecycle/
  20. media-compat/
  21. paging/
  22. percent/
  23. recommendation/
  24. room/
  25. samples/
  26. scripts/
  27. testutils/
  28. transition/
  29. tv-provider/
  30. v13/
  31. v14/
  32. v17/
  33. v4/
  34. v7/
  35. wear/
  36. .gitignore
  37. Android.mk
  38. build.gradle
  39. CleanSpec.mk
  40. droiddoc.mk
  41. gradle.properties
  42. gradlew
  43. LICENSE.txt
  44. makeFlatfootRepo.sh
  45. pathmap.mk
  46. PREUPLOAD.cfg
  47. README.md
  48. settings.gradle
README.md

AOSP Support Library Contribution Guide

Accepted Types of Contributions

  • Bug fixes (needs a corresponding bug report in b.android.com)
  • Each bug fix is expected to come with tests
  • Fixing spelling errors
  • Updating documentation
  • Adding new tests to the area that is not currently covered by tests

We are not currently accepting new modules, features, or behavior changes.

Checking Out the Code

NOTE: You will need to use Linux or Mac OS. Building under Windows is not currently supported.

Follow the “Downloading the Source” guide to install and set up repo tool, but instead of running the listed repo commands to initialize the repository, run the folowing:

repo init -u https://android.googlesource.com/platform/manifest -b ub-supportlib-master

Now your repository is set to pull only what you need for building and running support library. Download the code (and grab a coffee while we pull down 7GB):

repo sync -j8 -c

You will use this command to sync your checkout in the future - it’s similar to git fetch

Using Android Studio

Open path/to/checkout/frameworks/support/ in Android Studio. Now you're ready edit, run, and test!

If you get “Unregistered VCS root detected” click “Add root” to enable git integration for Android Studio.

If you see any warnings (red underlines) run Build > Clean Project.

Optional - Full Build

You can do most of your work from Android Studio, however you can also build the full support library from command line:

cd path/to/checkout/frameworks/support/
./gradlew createArchive

Running Tests

Single Test Class or Method

  1. Open the desired test file in Android Studio.
  2. Right-click on a test class or @Test method name and select Run FooBarTest

Full Test Package

  1. In the project side panel open the desired module.
  2. Find the directory with the tests
  3. Right-click on the directory and select Run android.support.foobar

Running Sample Apps

Support library has a set of Android applications that exercise support library code. These applications can be useful when you want to debug a real running application, or reproduce a problem interactively, before writing test code.

These applications are named support-*-demos (e.g. support-4v-demos or support-leanback-demos. You can run them by clicking Run > Run ... and choosing the desired application.

Making a change

cd path/to/checkout/frameworks/support/
repo start my_branch_name .
(make needed modifications)
git commit -a
repo upload --current-branch .

If you see the following prompt, choose always:

Run hook scripts from https://android.googlesource.com/platform/manifest (yes/always/NO)?

Getting reviewed

  • After you run repo upload, open r.android.com
  • Sign in into your account (or create one if you do not have one yet)
  • Add an appropriate reviewer (use git log to find who did most modifications on the file you are fixing)