Gitiles
Code Review Sign In
review.blissroms.org / platform_frameworks_support / e1e6029770007cf8db69eb14e732c77de0991c5f
commite1e6029770007cf8db69eb14e732c77de0991c5f[log] [tgz]
authorGustav Sennton <gsennton@google.com>Wed Apr 11 16:32:59 2018 +0100
committerGustav Sennton <gsennton@google.com>Wed Apr 11 16:32:59 2018 +0100
treef40019d6b6ab65bc88d3d099374eb1653726833b
parent904938d2e819ffe2ddcb66a3f784e60bef2c3d56 [diff]
[WebView Support Lib] Add test creating WebkitToCompatConverter.

Add a test to ensure we are not crashing when creating a
WebkitToCompatConverter. This test fails if we reference any post-L
classes in WebkitToCompatConverterBoundaryInterface because when we
create a Proxy for that interface the Proxy will look up all classes
referenced by that interface. At that point, if we're running on an L
device any post-L classes referenced will be undefined and cause a
crash.

Bug: crbug.com/831554
Test: run the test with and without the CL in
https://chromium-review.googlesource.com/c/chromium/src/+/1006960
the test fails without that fix, and passes with it.

Change-Id: I698a22f8eefdd6b9fbd783a85dfc1f9467c6d6fa
1 file changed
tree: f40019d6b6ab65bc88d3d099374eb1653726833b
  1. .idea/
  2. annotations/
  3. api/
  4. app-toolkit/
  5. asynclayoutinflater/
  6. browser/
  7. buildSrc/
  8. car/
  9. cardview/
  10. collection/
  11. compat/
  12. content/
  13. coordinatorlayout/
  14. core/
  15. cursoradapter/
  16. customview/
  17. development/
  18. documentfile/
  19. drawerlayout/
  20. dynamic-animation/
  21. emoji/
  22. exifinterface/
  23. fragment/
  24. frameworks/
  25. gradle/
  26. graphics/
  27. gridlayout/
  28. heifwriter/
  29. interpolator/
  30. jetifier/
  31. leanback/
  32. leanback-preference/
  33. legacy/
  34. lifecycle/
  35. loader/
  36. localbroadcastmanager/
  37. media/
  38. mediarouter/
  39. paging/
  40. palette/
  41. percent/
  42. persistence/
  43. preference/
  44. print/
  45. recommendation/
  46. recyclerview-selection/
  47. room/
  48. samples/
  49. scripts/
  50. slices/
  51. slidingpanelayout/
  52. swiperefreshlayout/
  53. testutils/
  54. testutils-ktx/
  55. textclassifier/
  56. transition/
  57. tv-provider/
  58. v7/
  59. viewpager/
  60. viewpager2/
  61. wear/
  62. webkit/
  63. webkit-codegen/
  64. .gitignore
  65. adding-support-library-as-included-build.md
  66. build.gradle
  67. gradle.properties
  68. gradlew
  69. include-composite-deps.gradle
  70. include-support-library.gradle
  71. LICENSE.txt
  72. OWNERS
  73. PREUPLOAD.cfg
  74. README.md
  75. settings.gradle
README.md

AOSP Support Library Contribution Guide

Accepted Types of Contributions

  • Bug fixes (needs a corresponding bug report in b.android.com)
  • Each bug fix is expected to come with tests
  • Fixing spelling errors
  • Updating documentation
  • Adding new tests to the area that is not currently covered by tests

We are not currently accepting new modules, features, or behavior changes.

Checking Out the Code

NOTE: You will need to use Linux or Mac OS. Building under Windows is not currently supported.

Follow the “Downloading the Source” guide to install and set up repo tool, but instead of running the listed repo commands to initialize the repository, run the folowing:

repo init -u https://android.googlesource.com/platform/manifest -b ub-supportlib-master

Now your repository is set to pull only what you need for building and running support library. Download the code (and grab a coffee while we pull down 7GB):

repo sync -j8 -c

You will use this command to sync your checkout in the future - it’s similar to git fetch

Using Android Studio

Open path/to/checkout/frameworks/support/ in Android Studio. Now you're ready edit, run, and test!

If you get “Unregistered VCS root detected” click “Add root” to enable git integration for Android Studio.

If you see any warnings (red underlines) run Build > Clean Project.

Builds

Full Build (Optional)

You can do most of your work from Android Studio, however you can also build the full support library from command line:

cd path/to/checkout/frameworks/support/
./gradlew createArchive

Building Support Library as part of your App build

If you intend to repeatedly make changes to Support Library and to wish to see the results in your app, and you don't want to have to repeatedly build them as separate Gradle projects, you can configure your app build to build Support Library too

Running Tests

Single Test Class or Method

  1. Open the desired test file in Android Studio.
  2. Right-click on a test class or @Test method name and select Run FooBarTest

Full Test Package

  1. In the project side panel open the desired module.
  2. Find the directory with the tests
  3. Right-click on the directory and select Run android.support.foobar

Running Sample Apps

Support library has a set of Android applications that exercise support library code. These applications can be useful when you want to debug a real running application, or reproduce a problem interactively, before writing test code.

These applications are named support-*-demos (e.g. support-4v-demos or support-leanback-demos. You can run them by clicking Run > Run ... and choosing the desired application.

Making a change

cd path/to/checkout/frameworks/support/
repo start my_branch_name .
(make needed modifications)
git commit -a
repo upload --current-branch .

If you see the following prompt, choose always:

Run hook scripts from https://android.googlesource.com/platform/manifest (yes/always/NO)?

Getting reviewed

  • After you run repo upload, open r.android.com
  • Sign in into your account (or create one if you do not have one yet)
  • Add an appropriate reviewer (use git log to find who did most modifications on the file you are fixing)