Gitiles
Code Review Sign In
review.blissroms.org / platform_frameworks_support / fd44fffced7cce36c1ce0d62dfe2542aa6a7c6e9
commitfd44fffced7cce36c1ce0d62dfe2542aa6a7c6e9[log] [tgz]
authorYohei Yukawa <yukawa@google.com>Fri Mar 24 16:08:01 2017 -0700
committerYohei Yukawa <yukawa@google.com>Tue Mar 28 14:33:36 2017 +0000
tree8235191811db6f366a567ecb3266087814eb2ebe
parent9e15382adf94b831acacbc2a48e03fb76cc00f29 [diff]
Deprecate IMM#showSoftInputUnchecked() part 3

This is an as-is port of the fix for android.widget.SearchView [1].

In short, the new approach is deterministic and does not need to
depend on @hide method. There is no good reason to continue using
non-deterministic private API.

 [1]: I20983e4ce1d625e098a8c2335ce75994cfa43235
      5cfc1b4c104471a6f4d0edc8a1b60cbc9a54d78f

Test: Manually checked the following scenario.
       1. Flash an OS image
       2. Complete the setup wizard.
       3. adb install -r support-v7-demos-debug.apk
       4. AppCompat -> Action Bar -> Action Bar Usage
       5. Tap the magnifier icon.
       6. Make sure that the software keyboard shows up
       7. Type "abcd"
       8. Tap the dismiss button to dismiss the keyboard
       9. Tap the text you entered ("abcd").
      10. Make sure that the software keyboard shows up
      11. Tap the dismiss button to dismiss the keyboard
      12. Tap the cross icon next to the text you typed ("abcd")
      13. Make sure that the software keyboard shows up
      on the following devices.
        * nakasi (Wi-Fi):
          * 4.1.2 JZO54K
          * 4.2.2 JDQ39
          * 4.4.4 KTU84P
          * 5.0.2 LRX22G
          * 5.1.1 LMY47V
        * bullhead:
          * 6.0.0 MDB08M
          * 6.0.1 MTC20K
          * 7.0.0 N5D91L (Nov 2016)
          * 7.1.1 N4F26T (Mar 2017)
Test: ./gradlew support-appcompat-v7:connectedCheck --info --daemon -Pandroid.testInstrumentationRunnerArguments.class=android.support.v7.widget.SearchViewTest
Test: ./gradlew support-appcompat-v7:connectedCheck --info --daemon -Pandroid.testInstrumentationRunnerArguments.class=android.support.v7.widget.SearchView_CursorTest
Bug: 36015425
Fixes: 36510749
Change-Id: Iaac4673a85c141c787b96fb39806346ccfb85fb3
1 file changed
tree: 8235191811db6f366a567ecb3266087814eb2ebe
  1. .idea/
  2. annotations/
  3. api/
  4. buildSrc/
  5. compat/
  6. core-ui/
  7. core-utils/
  8. customtabs/
  9. design/
  10. development/
  11. dynamic-animation/
  12. emoji/
  13. exifinterface/
  14. fragment/
  15. frameworks/
  16. gradle/
  17. graphics/
  18. instantvideo/
  19. media-compat/
  20. percent/
  21. recommendation/
  22. samples/
  23. scripts/
  24. testutils/
  25. transition/
  26. tv-provider/
  27. v13/
  28. v14/
  29. v17/
  30. v4/
  31. v7/
  32. wearable/
  33. .gitignore
  34. Android.mk
  35. build.gradle
  36. CleanSpec.mk
  37. droiddoc.mk
  38. gradle.properties
  39. gradlew
  40. pathmap.mk
  41. PREUPLOAD.cfg
  42. README.md
  43. settings.gradle
README.md

AOSP Support Library Contribution Guide

Accepted Types of Contributions

  • Bug fixes (needs a corresponding bug report in b.android.com)
  • Each bug fix is expected to come with tests
  • Fixing spelling errors
  • Updating documentation
  • Adding new tests to the area that is not currently covered by tests

We are not currently accepting new modules, features, or behavior changes.

Checking Out the Code

NOTE: You will need to use Linux or Mac OS. Building under Windows is not currently supported.

Follow the “Downloading the Source” guide to install and set up repo tool, but instead of running the listed repo commands to initialize the repository, run the folowing:

repo init -u https://android.googlesource.com/platform/manifest -b ub-supportlib-master

Now your repository is set to pull only what you need for building and running support library. Download the code (and grab a coffee while we pull down 7GB):

repo sync -j8 -c

You will use this command to sync your checkout in the future - it’s similar to git fetch

Using Android Studio

Open path/to/checkout/frameworks/support/ in Android Studio. Now you're ready edit, run, and test!

If you get “Unregistered VCS root detected” click “Add root” to enable git integration for Android Studio.

If you see any warnings (red underlines) run Build > Clean Project.

Optional - Full Build

You can do most of your work from Android Studio, however you can also build the full support library from command line:

cd path/to/checkout/frameworks/support/
./gradlew createArchive

Running Tests

Single Test Class or Method

  1. Open the desired test file in Android Studio.
  2. Right-click on a test class or @Test method name and select Run FooBarTest

Full Test Package

  1. In the project side panel open the desired module.
  2. Find the directory with the tests
  3. Right-click on the directory and select Run android.support.foobar

Running Sample Apps

Support library has a set of Android applications that exercise support library code. These applications can be useful when you want to debug a real running application, or reproduce a problem interactively, before writing test code.

These applications are named support-*-demos (e.g. support-4v-demos or support-leanback-demos. You can run them by clicking Run > Run ... and choosing the desired application.

Making a change

cd path/to/checkout/frameworks/support/
repo start my_branch_name .
(make needed modifications)
git commit -a
repo upload --current-branch .

If you see the following prompt, choose always:

Run hook scripts from https://android.googlesource.com/platform/manifest (yes/always/NO)?

Getting reviewed

  • After you run repo upload, open r.android.com
  • Sign in into your account (or create one if you do not have one yet)
  • Add an appropriate reviewer (use git log to find who did most modifications on the file you are fixing)