Merge "Camera: Clean up TODOs that aren't going to be addressed." into oc-dev
diff --git a/camera/common/1.0/default/CameraMetadata.cpp b/camera/common/1.0/default/CameraMetadata.cpp
index 0e7ef6e..4c54931 100644
--- a/camera/common/1.0/default/CameraMetadata.cpp
+++ b/camera/common/1.0/default/CameraMetadata.cpp
@@ -508,8 +508,6 @@
}
}
- // TODO: Make above get_camera_metadata_section_from_name ?
-
if (section == NULL) {
return NAME_NOT_FOUND;
} else {
diff --git a/camera/device/1.0/default/CameraDevice.cpp b/camera/device/1.0/default/CameraDevice.cpp
index 4f26c54..6f4e70f 100644
--- a/camera/device/1.0/default/CameraDevice.cpp
+++ b/camera/device/1.0/default/CameraDevice.cpp
@@ -183,7 +183,6 @@
}
int CameraDevice::sLockBuffer(struct preview_stream_ops*, buffer_handle_t*) {
- // TODO: make sure lock_buffer is indeed a no-op (and will always be)
return 0;
}
@@ -585,8 +584,6 @@
cameraInfo.facing = (CameraFacing) info.facing;
// Device 1.0 does not support external camera facing.
// The closest approximation would be front camera.
- // TODO: figure out should we override here or let
- // camera service handle it.
if (cameraInfo.facing == CameraFacing::EXTERNAL) {
cameraInfo.facing = CameraFacing::FRONT;
}
diff --git a/camera/provider/2.4/default/CameraProvider.cpp b/camera/provider/2.4/default/CameraProvider.cpp
index 791b93c..19f7bdd 100644
--- a/camera/provider/2.4/default/CameraProvider.cpp
+++ b/camera/provider/2.4/default/CameraProvider.cpp
@@ -461,10 +461,6 @@
return Void();
}
- // TODO: we also need to keep a wp list of all generated devices to notify
- // devices of device present status change, but then each device might
- // need a sp<provider> to keep provider alive until all device closed?
- // Problem: do we have external camera products to test this?
sp<android::hardware::camera::device::V3_2::implementation::CameraDevice> device =
new android::hardware::camera::device::V3_2::implementation::CameraDevice(
mModule, cameraId, mCameraDeviceNames);