commit 3e6fe754f647db202a7a455adcf1ab5d686105d3
author Mikhail Naganov <mnaganov@google.com> Mon Apr 24 10:44:08 2017 -0700
committer Mikhail Naganov <mnaganov@google.com> Tue Apr 25 20:21:37 2017 +0000
tree 13bdb0cc84a0295c4f192027201e557f0cf69f42
parent 1fd47b29b3f06fe032c57f809b494e1599f50194

audiohal: Fix handling of invalid arguments in 'debugDump' methods

Add checks for validity of the passed in native handle.

Bug: 37590777
Change-Id: If906f0086c3442819e1844cc521215d5b74af015
Test: VTS
(cherry picked from commit 7bae6a0b635b142cfba9d4c4612e1e114f85b842)

audio/2.0/default/Stream.cpp

diff --git a/audio/2.0/default/Stream.cpp b/audio/2.0/default/Stream.cpp
index 29946fe..671f171 100644
--- a/audio/2.0/default/Stream.cpp
+++ b/audio/2.0/default/Stream.cpp
@@ -226,7 +226,7 @@
 }
 
 Return<void> Stream::debugDump(const hidl_handle& fd)  {
-    if (fd->numFds == 1) {
+    if (fd.getNativeHandle() != nullptr && fd->numFds == 1) {
         analyzeStatus("dump", mStream->dump(mStream, fd->data[0]));
     }
     return Void();