tree 690a1574c8830eb3e7fd6302d9ce97465e2605e6
parent 5331371a3aa6d61546866f81a4ddea0220b901f0
author Bartosz Fabianowski <bartfab@google.com> 1487001024 +0100
committer Bartosz Fabianowski <bartfab@google.com> 1487067878 +0100

Have generateKey() treat additional entropy as optional

KeyStore.generateKey() takes an entropy parameter. This is optional
and can be null. That is how KeyStore used to work but a recent
refactor made us always feed the entropy to keymaster, even if it
is empty (null or byte[0] on the Java side). This CL makes us ignore
such empty entropy again.

We only noticed this because a recently added GTS test that happens
to set the entropy to null is failing on some hardware (other
keymaster implementations silently ignore this invalid attempt to
set entropy).

Bug: 35156555
Test: gts-tradefed run gts --module GtsGmscoreHostTestCases
      --test com.google.android.gts.security.DeviceIdAttestationHostTest

Change-Id: Iadaf40e69350c17dd18e4dc2a1dab97fa911e1bf