Clarifying comments and todos, update current.txt.
**Note, hashes are being modified in place ONLY
because this interface has not yet been released
in a release of Android.
Updated comments for clarity nearby
some removed todo's on telephony APN
and GNSS demodulated satellite data bits.
Fixes: 34108918
Test: Built & run on Pixel, GPS & XTRA pass.
Change-Id: Ia67be4c4c095479bbbf001987c1629b57ca864a5
diff --git a/gnss/1.0/IAGnssRil.hal b/gnss/1.0/IAGnssRil.hal
index 6f91f7f..12289f6 100644
--- a/gnss/1.0/IAGnssRil.hal
+++ b/gnss/1.0/IAGnssRil.hal
@@ -131,14 +131,13 @@
generates (bool success);
/**
- * Notify GNSS of network status changes.
+ * Notify GNSS of network status changes and current APN.
*
* @param available Indicates whether network connectivity is available.
- * @param apn String containing the Access Point Name.
+ * @param apn String containing the telephony preferred Access Point Name.
*
* @return success True if all parameters were valid and the operation was
* successful.
- * TODO(b/32022567): Add VTS test to validate the format of APN.
*/
updateNetworkAvailability(bool available, string apn) generates (bool success);
diff --git a/gnss/1.0/IGnssNavigationMessageCallback.hal b/gnss/1.0/IGnssNavigationMessageCallback.hal
index 714351b..e18f7e2 100644
--- a/gnss/1.0/IGnssNavigationMessageCallback.hal
+++ b/gnss/1.0/IGnssNavigationMessageCallback.hal
@@ -51,11 +51,11 @@
/**
* Status of Navigation Message
* When a message is received properly without any parity error in its
- * navigation words, the status must be set to PARITY_PASSED. But if a message is
- * received with words that failed parity check, but GNSS is able to correct
- * those words, the status must be set to PARITY_REBUILT.
- * No need to send any navigation message that contains words with parity error
- * and cannot be corrected.
+ * navigation words, the status must be set to PARITY_PASSED.
+ * If a message is received with words that failed a parity check, but the GNSS
+ * receiver has corrected those words, the status must be set to PARITY_REBUILT.
+ * Do not send any navigation message that contains words with parity errors
+ * that cannot be corrected.
*/
@export(name="navigation_message_status", value_prefix="NAV_MESSAGE_STATUS_")
enum NavigationMessageStatus : uint16_t {
@@ -80,7 +80,7 @@
/**
* The status of the received navigation message.
* No need to send any navigation message that contains words with parity
- * error and cannot be corrected.
+ * errors that cannot be corrected.
*/
bitfield<NavigationMessageStatus> status;
@@ -125,8 +125,7 @@
/**
* The data of the reported GNSS message. The bytes (or words) are specified
- * using big endian format (MSB first). The data is stored and decoded
- * in a server for research purposes.
+ * using big endian format (MSB first).
*
* - For GNSS L1 C/A, Beidou D1 & Beidou D2, each subframe contains 10 30-bit
* words. Each word (30 bits) must fit into the last 30 bits in a
@@ -150,10 +149,9 @@
* into 29 bytes, with MSB first (skip B229-B232). The standard followed
* is same as above.
*
- * TODO(b/32022567): Describe this relationship with data to the VTS
- * via custom annotations and plug in a VTS test to verify that the data
- * correctly follows the standard.
- *
+ * The data reported here must be the raw data as demodulated by the GNSS
+ * receiver, not data received from an external source (i.e. not from a server
+ * download.)
*/
vec<uint8_t> data;
};