| commit | d67ae54f8e89f01373dfd59592a0532462f45d20 | [log] [tgz] |
|---|---|---|
| author | Ivan Vecera <ivan@cera.cz> | Mon Jun 26 13:10:07 2023 +0200 |
| committer | Bruno Martins <bgcngm@gmail.com> | Mon Jun 26 15:20:07 2023 +0200 |
| tree | 8af160b179c294b330eacecc47184fcc052e1f4d | |
| parent | e386376f9c3ce006f2c5e4d8f91432624caf238a [diff] |
compat: Fix ABI issues Several constructor shims are implemented incorrectly because they completely ignore the fact that constructors have 'this-call' calling convention and should pass 'this ptr' as the first argument [1] as well as its return value, at least according ARM ABI [2]. Additionally android::SurfaceComposerClient::Transaction::apply(bool) shim has void return value instead of status_t so the caller retrieves random value. [1] https://review.lineageos.org/c/LineageOS/android_device_xiaomi_sdm710-common/+/360011/comments/eb6600df_3e2fb434 [2] https://github.com/ARM-software/abi-aa/blob/617079d8a0d45bec83d351974849483cf0cc66d5/cppabi32/cppabi32.rst?plain=1#L576 Change-Id: I7b14b5d3ca6008c1e4b3f5fcbaece5021b3cbb82 Signed-off-by: Ivan Vecera <ivan@cera.cz>