commit 19dd0c14f0a55af084a0b566c627703b3ce6d03c
author Sandhya Mutha Naga Venkata <quic_smuthana@quicinc.com> Tue Jul 12 14:54:43 2022 +0530
committer Gerrit - the friendly Code Review server <code-review@localhost> Mon Jul 18 13:24:52 2022 -0700
tree 9b3475ff9ce17ffd8de931610ee3d05b0f75ecc4
parent 00ce93d6a544145a9f51fff17a908eb771eba7f4

 audio: hal: Avoid input device check for playback use case

- For HFP/voice call use case, crash is seen when setting up playback path.

- Direct access to the list cause null pointer dereference.

- Added empty list check before access.

Change-Id: Iefd893fe367d004f01f71583e21f5d13d1a8e4a2

hal/audio_hw.c

diff --git a/hal/audio_hw.c b/hal/audio_hw.c
index 05a33b4..5a284ea 100644
--- a/hal/audio_hw.c
+++ b/hal/audio_hw.c
@@ -804,7 +804,7 @@
 
 bool is_combo_audio_input_device(struct listnode *devices){
 
-    if (devices == NULL)
+    if ((devices == NULL) || (!list_empty(devices)))
         return false;
 
     if(compare_device_type(devices, AUDIO_DEVICE_IN_BUILTIN_MIC|AUDIO_DEVICE_IN_SPEAKER_MIC2))