commit 1a32f5e7f2deef611cb8566f9069589a62396fba
author justinweng <justinweng@google.com> Wed Mar 27 20:27:06 2019 +0800
committer justinweng <justinweng@google.com> Tue Apr 09 14:53:49 2019 +0800
tree 371ca3549168db330f93cb057697aa1dfb1517e7
parent c69dce0780a7e3cdf5d4fa44cd6352e685177202

audio: hal: do not convert zoom value in audio hal

Bug: 125191693
Test: set parameters successfully

Change-Id: Idcc0944fac882a0204fe2ac7f9210a6524c61a44
Signed-off-by: justinweng <justinweng@google.com>

hal/audio_extn/audiozoom.c

diff --git a/hal/audio_extn/audiozoom.c b/hal/audio_extn/audiozoom.c
index 86d53b4..73e4862 100644
--- a/hal/audio_extn/audiozoom.c
+++ b/hal/audio_extn/audiozoom.c
@@ -31,7 +31,6 @@
 #include <resolv.h>
 
 #define AUDIOZOOM_PRESET_FILE "/vendor/etc/audiozoom.xml"
-#define MIN_BUFSIZE 8
 
 typedef struct qdsp_audiozoom_cfg {
     uint32_t             topo_id;
@@ -190,8 +189,9 @@
 {
     struct audio_device *adev = in->dev;
     struct str_parms *parms = str_parms_create();
-    uint8_t value[MIN_BUFSIZE] = {0};
-    char data[MIN_BUFSIZE * 2] = {0};
+    /* The encoding process in b64_ntop represents 24-bit groups of input bits
+       as output strings of 4 encoded characters. */
+    char data[((sizeof(zoom) + 2) / 3) * 4 + 1] = {0};
     int32_t ret;
 
     if (zoom > 1.0 || zoom < 0)
@@ -208,10 +208,7 @@
     str_parms_add_int(parms, "cal_instanceid", qdsp_audiozoom.instance_id);
     str_parms_add_int(parms, "cal_paramid", qdsp_audiozoom.zoom_param_id);
 
-    zoom *= 255;
-    value[0] = (uint8_t) zoom; /* Valid value is 0 to 255 */
-
-    ret = b64_ntop(value, sizeof(value), data, sizeof(data));
+    ret = b64_ntop((uint8_t*)&zoom, sizeof(zoom), data, sizeof(data));
     if (ret > 0) {
         str_parms_add_str(parms, "cal_data", data);