commit 48c824319feedc97e3ed44ca40c7dc83f3de91dd
author Andy Hung <hunga@google.com> Fri Nov 04 16:02:51 2016 -0700
committer Andy Hung <hunga@google.com> Fri Nov 04 16:15:17 2016 -0700
tree 3e98ed938ba07d1a026a7df8a3e019cf137d93d2
parent 72b45d6c01d9fe68aa93ae222be48da41b1b83bc

Fix error handling return on volume listener

Test: Custom crafted test
Bug: 32669549
Change-Id: I17218ae7c5b046c89419e0040784788df20be774

post_proc/volume_listener.c

diff --git a/post_proc/volume_listener.c b/post_proc/volume_listener.c
index 4a48a25..6d9ca7a 100644
--- a/post_proc/volume_listener.c
+++ b/post_proc/volume_listener.c
@@ -358,7 +358,9 @@
             ALOGE("%s: EFFECT_CMD_INIT: %s, sending -EINVAL", __func__,
                   (p_reply_data == NULL) ? "p_reply_data is NULL" :
                   "*reply_size != sizeof(int)");
-            return -EINVAL;
+            android_errorWriteLog(0x534e4554, "32669549");
+            status = -EINVAL;
+            goto exit;
         }
         *(int *)p_reply_data = 0;
         break;
@@ -367,7 +369,9 @@
         ALOGV("%s :: cmd called EFFECT_CMD_SET_CONFIG", __func__);
         if (p_cmd_data == NULL || cmd_size != sizeof(effect_config_t)
                 || p_reply_data == NULL || reply_size == NULL || *reply_size != sizeof(int)) {
-            return -EINVAL;
+            android_errorWriteLog(0x534e4554, "32669549");
+            status = -EINVAL;
+            goto exit;
         }
         context->config = *(effect_config_t *)p_cmd_data;
         *(int *)p_reply_data = 0;
@@ -391,7 +395,9 @@
             ALOGE("%s: EFFECT_CMD_OFFLOAD: %s, sending -EINVAL", __func__,
                   (p_reply_data == NULL) ? "p_reply_data is NULL" :
                   "*reply_size != sizeof(int)");
-            return -EINVAL;
+            android_errorWriteLog(0x534e4554, "32669549");
+            status = -EINVAL;
+            goto exit;
         }
         *(int *)p_reply_data = 0;
         break;