commit 79e7c952fa7869bb9543b5c229547a9a8b4ad63e
author Surendar Karka <skarka@codeaurora.org> Fri May 11 18:56:49 2018 +0530
committer Surendar Karka <skarka@codeaurora.org> Thu May 17 15:32:12 2018 +0530
tree 980603ae155064adcff868f5def293639880a2c5
parent d6d24596d6d26402cddbd7883e2c68ad236131c6

qahw_api: call unlinkToDeath to avoid segmentation fault

Segmentation fault is observed while client cleaning
up/closing the session as death notifier is not released.
Calling unlinkToDeath to avoid segmentation fault.

Change-Id: Ibc855396a25b80103302298306438e84c29eda23

qahw_api/src/qahw_api.cpp

diff --git a/qahw_api/src/qahw_api.cpp b/qahw_api/src/qahw_api.cpp
index 8967e79..cbd9041 100644
--- a/qahw_api/src/qahw_api.cpp
+++ b/qahw_api/src/qahw_api.cpp
@@ -1113,6 +1113,7 @@
 
 int qahw_unload_module(qahw_module_handle_t *hw_module)
 {
+    int rc = -EINVAL;
     ALOGV("%d:%s",__LINE__, __func__);
     if (g_binder_enabled) {
         if (!g_qas_died && ((g_qas_load_count > 0) && (--g_qas_load_count == 0))) {
@@ -1120,7 +1121,13 @@
             if (qas_status(qas) == -1)
                 return -ENODEV;
             pthread_mutex_destroy(&list_lock);
-            return qas->qahw_unload_module(hw_module);
+            rc = qas->qahw_unload_module(hw_module);
+            if (g_death_notifier != NULL) {
+                IInterface::asBinder(qas)->unlinkToDeath(g_death_notifier);
+                g_death_notifier.clear();
+            }
+            g_qas = NULL;
+            return rc;
         } else {
             return -ENODEV;
         }