commit 7de6352d67212154f8c8929544ca6c9cec2a78fa
author Aniket Kumar Lata <alata@codeaurora.org> Thu Jun 13 11:05:18 2019 -0700
committer Aniket Kumar Lata <alata@codeaurora.org> Thu Jun 13 11:07:06 2019 -0700
tree 176a00c95c6fec4aaa789794a92de03ee4ca2a0d
parent 637e2d4f710eb1feb7884643731c6ce9d3a2a35f

hal: Fix potential NULL dereference

Fix potential NULL dereference of active input stream.

Change-Id: I65287fe928d1a357f0bba9696af008bd2eaec870

hal/audio_hw.c

diff --git a/hal/audio_hw.c b/hal/audio_hw.c
index 9b7bd1f..3425175 100644
--- a/hal/audio_hw.c
+++ b/hal/audio_hw.c
@@ -919,6 +919,11 @@
     long set_values[6];
     struct stream_in *in = adev_get_active_input(adev);
 
+    if (in == NULL) {
+        ALOGE("%s: active input stream is NULL", __func__);
+        return -EINVAL;
+    }
+
     ctl = mixer_get_ctl_by_name(adev->mixer, mixer_ctl_name);
     if (!ctl) {
         ALOGE("%s: Could not get mixer ctl - %s",
@@ -947,6 +952,11 @@
     struct audio_usecase *usecase = NULL;
     struct stream_in *in = adev_get_active_input(adev);
 
+    if (in == NULL) {
+        ALOGE("%s: active input stream is NULL", __func__);
+        return -EINVAL;
+    }
+
     usecase = get_usecase_from_list(adev, in->usecase);
     if (!usecase)
         return -EINVAL;