commit 7ffa39c45458a3e39210304ef8f5173b52ba486a
author Andy Hung <hunga@google.com> Thu Apr 28 13:43:44 2016 -0700
committer Andy Hung <hunga@google.com> Fri Apr 29 15:41:59 2016 -0700
tree 391f2d89d5e741b950e242c0b7fe8093fa28b0f6
parent 34fa769ab5835cefb9a6b842590f5f690c0a52db

DO NOT MERGE Fix AudioEffect reply overflow

Bug: 28173666
Change-Id: I055af37a721b20c5da0f1ec4b02f630dcd5aee02

voice_processing/voice_processing.c

diff --git a/voice_processing/voice_processing.c b/voice_processing/voice_processing.c
index b8b1e1b..9543f96 100644
--- a/voice_processing/voice_processing.c
+++ b/voice_processing/voice_processing.c
@@ -559,7 +559,9 @@
             if (pCmdData == NULL ||
                     cmdSize < (int)sizeof(effect_param_t) ||
                     pReplyData == NULL ||
-                    *replySize < (int)sizeof(effect_param_t)) {
+                    *replySize < (int)sizeof(effect_param_t) ||
+                    // constrain memcpy below
+                    ((effect_param_t *)pCmdData)->psize > *replySize - sizeof(effect_param_t)) {
                 ALOGV("fx_command() EFFECT_CMD_GET_PARAM invalid args");
                 return -EINVAL;
             }