commit 96eb576bb74f045232a9fc2a5851ae50ffd78fe8
author Dhanalakshmi Siddani <dsiddani@codeaurora.org> Mon Dec 11 11:56:46 2017 +0530
committer Dhanalakshmi Siddani <dsiddani@codeaurora.org> Mon Dec 18 16:52:11 2017 +0530
tree 3dc22096370b6bc97bf18565786ef15da0b147f1
parent e27bd055d0df07b3548e577d5b70fdf5ce8a7d74

hal: Fix test app crash issue

Test app crash observed while freeing up the memory
after parsing meta key info from xml file.
Fix this by using list_for_each_safe.

CRs-Fixed: 2156567
Change-Id: Ib39079ee4772a20f6f506d32d0fea67ef1a35535

hal/acdb.c

diff --git a/hal/acdb.c b/hal/acdb.c
index cbb96bd..182e513 100644
--- a/hal/acdb.c
+++ b/hal/acdb.c
@@ -143,10 +143,12 @@
         if (my_data->acdb_handle)
             dlclose(my_data->acdb_handle);
 
-        struct listnode *node;
-        struct meta_key_list *key_info;
-        list_for_each(node, &my_data->acdb_meta_key_list) {
+        struct listnode *node = NULL;
+        struct meta_key_list *key_info = NULL;
+        struct listnode *tempnode = NULL;
+        list_for_each_safe(node, tempnode, &my_data->acdb_meta_key_list) {
             key_info = node_to_item(node, struct meta_key_list, list);
+            list_remove(node);
             free(key_info);
         }
         free(my_data);