commit d6b0d720e241ca01875b49f50eb38e81f8a562a0
author Quinn Male <qmale@codeaurora.org> Thu Jun 18 13:03:49 2020 -0700
committer Quinn Male <qmale@codeaurora.org> Thu Jun 18 13:03:49 2020 -0700
tree db5bed11552c229004662195115546c6ba7aecd7
parent a7fe0f81ba69b84c79b73776c1894bab9568a250

hal: Fix static analysis issue

Must check if a string is NULL before calling str_parms_to_str().

Change-Id: I4f386fdd0feb6bb25ea0ae4a34b4dc419aa3708c

hal/audio_extn/soundtrigger.c

diff --git a/hal/audio_extn/soundtrigger.c b/hal/audio_extn/soundtrigger.c
index 6818522..04f2268 100644
--- a/hal/audio_extn/soundtrigger.c
+++ b/hal/audio_extn/soundtrigger.c
@@ -753,12 +753,14 @@
     audio_event_info_t event;
     int ret;
     char value[32], paramstr[MAX_STR_LENGTH_FFV_PARAMS];
-    char *kv_pairs = str_parms_to_str(query);
+    char *kv_pairs = NULL;
 
-    if (query == NULL || reply == NULL || kv_pairs == NULL) {
+    if (query == NULL || reply == NULL) {
         ALOGD("%s: query is null or reply is null",__func__);
         return;
     }
+
+    kv_pairs = str_parms_to_str(query);
     ALOGD("%s input string<%s>", __func__, kv_pairs);
 
     ret = str_parms_get_str(query, "SVA_EXEC_MODE_STATUS", value,