commit f57ff2aee696354be710dfabbae6fcf6cd4506d2
author Ramjee Singh <ramjee@codeaurora.org> Mon Aug 27 16:22:16 2018 +0530
committer Gerrit - the friendly Code Review server <code-review@localhost> Tue Aug 28 04:39:01 2018 -0700
tree 4947fcb6990eed451e75edfd968045da3dc72070
parent e4c9c814bd4e71405bf509b70df91ad5082abd98

hal: Fix for parsing platform info xml.

- platform_info contains three values for orientation and
  geo location. platform_info core logic only parses 2
  fields.
- Fix is to parse all fields for orientation and mic geo
  location.

Change-Id: I787a11531301fa7b0fdd15d3f82ffb6a72b41a9a

hal/platform_info.c

diff --git a/hal/platform_info.c b/hal/platform_info.c
index e35b7c4..3341f20 100644
--- a/hal/platform_info.c
+++ b/hal/platform_info.c
@@ -639,7 +639,7 @@
         goto done;
     }
     microphone.num_frequency_responses = atoi(attr[curIdx++]);
-    if (microphone.num_frequency_responses >= AUDIO_MICROPHONE_MAX_FREQUENCY_RESPONSES) {
+    if (microphone.num_frequency_responses > AUDIO_MICROPHONE_MAX_FREQUENCY_RESPONSES) {
         ALOGE("%s: num_frequency_responses is too large", __func__);
         goto done;
     }
@@ -654,8 +654,7 @@
         while (token) {
             microphone.frequency_responses[0][num_frequencies++] = atof(token);
             if (num_frequencies >= AUDIO_MICROPHONE_MAX_FREQUENCY_RESPONSES) {
-                ALOGE("%s: num %u of frequency is too large", __func__, num_frequencies);
-                goto done;
+                break;
             }
             token = strtok_r(NULL, " ", &context);
         }
@@ -669,8 +668,7 @@
         while (token) {
             microphone.frequency_responses[1][num_responses++] = atof(token);
             if (num_responses >= AUDIO_MICROPHONE_MAX_FREQUENCY_RESPONSES) {
-                ALOGE("%s: num %u of response is too large", __func__, num_responses);
-                goto done;
+                break;
             }
             token = strtok_r(NULL, " ", &context);
         }
@@ -725,12 +723,11 @@
         while (token) {
             orientation[idx++] = atof(token);
             if (idx >= 3) {
-                ALOGE("%s: orientation invalid", __func__);
-                goto done;
+                break;
             }
             token = strtok_r(NULL, " ", &context);
         }
-        if (idx != 2) {
+        if (idx != 3) {
             ALOGE("%s: orientation invalid", __func__);
             goto done;
         }
@@ -755,12 +752,11 @@
         while (token) {
             geometric_location[idx++] = atof(token);
             if (idx >= 3) {
-                ALOGE("%s: geometric_location invalid", __func__);
-                goto done;
+                break;
             }
             token = strtok_r(NULL, " ", &context);
         }
-        if (idx != 2) {
+        if (idx != 3) {
             ALOGE("%s: geometric_location invalid", __func__);
             goto done;
         }