commit fa7e928944e7db84c2e85266bf170c29972b47b9
author rago <rago@google.com> Thu Oct 13 02:34:26 2016 +0000
committer android-build-merger <android-build-merger@google.com> Thu Oct 13 02:34:26 2016 +0000
tree 677d5e6b6bdcd8e81c22635e04e8ddda74a9b0d1
parent 2d809e0d104497ca6b7a1e1be4efdf7856070aa5
parent 6ae401595dcab17815a885cde65343762d59acab

Fix potential NULL dereference in Visualizer effect am: 0c39abc483 am: 18b2de20a7 am: bcd048aea2 am: 67c5eb2059 am: 996c0f33a8 am: ae2849ff1d am: b69cec19a6 am: e8b78f62df am: a8f0a1ff6e am: bd78fe1fef am: dc3ca4acef
am: 6ae401595d

Change-Id: I2df74e12ca8c4d305a43d43fdc227cc3b41cc205

visualizer/offload_visualizer.c

diff --git a/visualizer/offload_visualizer.c b/visualizer/offload_visualizer.c
index 69cea57..c56ebff 100644
--- a/visualizer/offload_visualizer.c
+++ b/visualizer/offload_visualizer.c
@@ -869,9 +869,13 @@
     case VISUALIZER_CMD_MEASURE: {
         if (pReplyData == NULL || replySize == NULL ||
                 *replySize < (sizeof(int32_t) * MEASUREMENT_COUNT)) {
-            ALOGV("%s VISUALIZER_CMD_MEASURE error *replySize %d <"
-                    "(sizeof(int32_t) * MEASUREMENT_COUNT) %d",
-                    __func__, *replySize, sizeof(int32_t) * MEASUREMENT_COUNT);
+            if (replySize == NULL) {
+                ALOGV("%s VISUALIZER_CMD_MEASURE error replySize NULL", __func__);
+            } else {
+                ALOGV("%s VISUALIZER_CMD_MEASURE error *replySize %u <"
+                        "(sizeof(int32_t) * MEASUREMENT_COUNT) %zu",
+                        __func__, *replySize, sizeof(int32_t) * MEASUREMENT_COUNT);
+            }
             android_errorWriteLog(0x534e4554, "30229821");
             return -EINVAL;
         }