commit 1023ce2fdd0c7d82b70d075757503a9ff3eee2a6
author Saurabh Shah <saurshah@codeaurora.org> Wed Sep 05 18:45:59 2012 -0700
committer Iliyan Malchev <malchev@google.com> Sun Sep 09 14:19:55 2012 -0700
tree 32972f5caff67f276943e9bfda3b13625e8307e3
parent ae1044e0cbab8d26851782e85525ee9e0e6127e6

hwc: video: Create crop and position structs only once.

Create crop and position structs only once.
Fix bug where x and y were not updated.

Change-Id: I7c6a873ba207997baa302b8999bdaf34cc938dba

libhwcomposer/hwc_video.cpp

diff --git a/libhwcomposer/hwc_video.cpp b/libhwcomposer/hwc_video.cpp
index 38ac695..bedd9e9 100644
--- a/libhwcomposer/hwc_video.cpp
+++ b/libhwcomposer/hwc_video.cpp
@@ -130,17 +130,7 @@
     ov.setSource(pargs, ovutils::OV_PIPE0);
 
     hwc_rect_t sourceCrop = layer->sourceCrop;
-    // x,y,w,h
-    ovutils::Dim dcrop(sourceCrop.left, sourceCrop.top,
-            sourceCrop.right - sourceCrop.left,
-            sourceCrop.bottom - sourceCrop.top);
-
-    ovutils::Dim dpos;
     hwc_rect_t displayFrame = layer->displayFrame;
-    dpos.x = displayFrame.left;
-    dpos.y = displayFrame.top;
-    dpos.w = (displayFrame.right - displayFrame.left);
-    dpos.h = (displayFrame.bottom - displayFrame.top);
 
     //Calculate the rect for primary based on whether the supplied position
     //is within or outside bounds.
@@ -153,19 +143,13 @@
             displayFrame.top < 0 ||
             displayFrame.right > fbWidth ||
             displayFrame.bottom > fbHeight) {
-
         calculate_crop_rects(sourceCrop, displayFrame, fbWidth, fbHeight);
-
-        //Update calculated width and height
-        dcrop.w = sourceCrop.right - sourceCrop.left;
-        dcrop.h = sourceCrop.bottom - sourceCrop.top;
-
-        dpos.x = displayFrame.left;
-        dpos.y = displayFrame.top;
-        dpos.w = displayFrame.right - displayFrame.left;
-        dpos.h = displayFrame.bottom - displayFrame.top;
     }
 
+    // source crop x,y,w,h
+    ovutils::Dim dcrop(sourceCrop.left, sourceCrop.top,
+            sourceCrop.right - sourceCrop.left,
+            sourceCrop.bottom - sourceCrop.top);
     //Only for Primary
     ov.setCrop(dcrop, ovutils::OV_PIPE0);
 
@@ -174,6 +158,11 @@
             static_cast<ovutils::eTransform>(transform);
     ov.setTransform(orient, ovutils::OV_PIPE0);
 
+    // position x,y,w,h
+    ovutils::Dim dpos(displayFrame.left,
+            displayFrame.top,
+            displayFrame.right - displayFrame.left,
+            displayFrame.bottom - displayFrame.top);
     ov.setPosition(dpos, ovutils::OV_PIPE0);
 
     if (!ov.commit(ovutils::OV_PIPE0)) {