commit 52ca6d2747ec9b46f7fff666f3b35ec1d3f1ce13
author Naseer Ahmed <naseer@codeaurora.org> Mon Oct 08 14:03:01 2012 -0400
committer Iliyan Malchev <malchev@google.com> Mon Oct 08 13:18:40 2012 -0700
tree 894b30a8a1e25b5cb3d21c9956dc7793010cdb9f
parent ae823e773536ee9b6cf97c575463f1a9902370d9

display/libhwcomposer: fix potential memory leak

This changes fixes a memory leak, by freeing up the pipe alloc structure
everytime before parsing the current frame.

related-to-bug: 7301196
Change-Id: I23edefca71ec0209291be24ee9d629b4a80f0a25
Acked-by: Jeykumar Sankaran<jsanka@codeaurora.org>
Signed-off-by: Iliyan Malchev <malchev@google.com>

libhwcomposer/hwc_mdpcomp.cpp

diff --git a/libhwcomposer/hwc_mdpcomp.cpp b/libhwcomposer/hwc_mdpcomp.cpp
index 4c4a9a0..213b74e 100644
--- a/libhwcomposer/hwc_mdpcomp.cpp
+++ b/libhwcomposer/hwc_mdpcomp.cpp
@@ -130,8 +130,10 @@
     }
 
     sCurrentFrame.count = 0;
-    free(sCurrentFrame.pipe_layer);
-    sCurrentFrame.pipe_layer = NULL;
+    if(sCurrentFrame.pipe_layer) {
+        free(sCurrentFrame.pipe_layer);
+        sCurrentFrame.pipe_layer = NULL;
+    }
 
     //Reset MDP pipes
     sPipeMgr.reset();
@@ -585,6 +587,11 @@
     frame_info &current_frame = sCurrentFrame;
     current_frame.count = 0;
 
+    if(current_frame.pipe_layer) {
+        free(current_frame.pipe_layer);
+        current_frame.pipe_layer = NULL;
+    }
+
     if(!ctx) {
        ALOGE("%s: invalid context", __FUNCTION__);
        return -1;