hwc: Use intermediate buffers for copybit
The earlier copybit solution involved blitting directly into
the SurfaceFlinger's framebuffer target. That solution involved
unnecessary framework changes and caused issues when the
framebuffer was being written to both by GL and copybit.
Update hwc_copybit to use our own buffers for this purpose.
We also make sure we display only the region we're interested in
so that unnecessary artifacts from previous blits do not show up
on the display. This way, we can avoid clearing the intermediate
buffers every frame.
Change-Id: I713b3fc606e0768444c621af76853ece41964da1
diff --git a/libhwcomposer/hwc_utils.cpp b/libhwcomposer/hwc_utils.cpp
index 82ab25c..5193644 100644
--- a/libhwcomposer/hwc_utils.cpp
+++ b/libhwcomposer/hwc_utils.cpp
@@ -364,6 +364,33 @@
crop_b -= crop_h * bottomCutRatio;
}
+void getNonWormholeRegion(hwc_display_contents_1_t* list,
+ hwc_rect_t& nwr)
+{
+ uint32_t last = list->numHwLayers - 1;
+ hwc_rect_t fbDisplayFrame = list->hwLayers[last].displayFrame;
+ //Initiliaze nwr to first frame
+ nwr.left = list->hwLayers[0].displayFrame.left;
+ nwr.top = list->hwLayers[0].displayFrame.top;
+ nwr.right = list->hwLayers[0].displayFrame.right;
+ nwr.bottom = list->hwLayers[0].displayFrame.bottom;
+
+ for (uint32_t i = 1; i < last; i++) {
+ hwc_rect_t displayFrame = list->hwLayers[i].displayFrame;
+ nwr.left = min(nwr.left, displayFrame.left);
+ nwr.top = min(nwr.top, displayFrame.top);
+ nwr.right = max(nwr.right, displayFrame.right);
+ nwr.bottom = max(nwr.bottom, displayFrame.bottom);
+ }
+
+ //Intersect with the framebuffer
+ nwr.left = max(nwr.left, fbDisplayFrame.left);
+ nwr.top = max(nwr.top, fbDisplayFrame.top);
+ nwr.right = min(nwr.right, fbDisplayFrame.right);
+ nwr.bottom = min(nwr.bottom, fbDisplayFrame.bottom);
+
+}
+
bool isExternalActive(hwc_context_t* ctx) {
return ctx->dpyAttr[HWC_DISPLAY_EXTERNAL].isActive;
}
@@ -452,6 +479,8 @@
fd = -1;
}
+ if (ctx->mCopyBit[dpy])
+ ctx->mCopyBit[dpy]->setReleaseFd(releaseFd);
if(UNLIKELY(swapzero)){
list->retireFenceFd = -1;
close(releaseFd);