commit 8181cef67a82d4328745c7d4f5a7c9a333f27dd1
author Mohan Pallaka <mpallaka@codeaurora.org> Tue Aug 21 14:41:12 2018 -0700
committer Mohan Pallaka <mpallaka@codeaurora.org> Mon Aug 27 08:26:12 2018 -0700
tree 0ed5182626ad37e668792c851183b4d13d2df24e
parent 5d8144382d315b925763ca495fe2d3ec42481afc

Gralloc: Use 4 bytes padding for private_handle_t

Force 4 bytes padding to avoid data leak due to uninitialized padding.

Bug: 77237704
Change-Id: I3922bf62bfa6c78806a6d5fd969e2d9faf067abe
CRs-Fixed: 2257685

gralloc/gr_priv_handle.h

diff --git a/gralloc/gr_priv_handle.h b/gralloc/gr_priv_handle.h
index 964bed0..39e5e20 100644
--- a/gralloc/gr_priv_handle.h
+++ b/gralloc/gr_priv_handle.h
@@ -33,6 +33,7 @@
 
 #define PRIV_HANDLE_CONST(exp) static_cast<const private_handle_t *>(exp)
 
+#pragma pack(push, 4)
 struct private_handle_t : public native_handle_t {
   enum {
     PRIV_FLAGS_FRAMEBUFFER = 0x00000001,
@@ -75,15 +76,15 @@
   int format;
   int buffer_type;
   unsigned int layer_count;
-  uint64_t id __attribute__((aligned(8)));
-  uint64_t usage __attribute__((aligned(8)));
+  uint64_t id;
+  uint64_t usage;
 
   unsigned int size;
   unsigned int offset;
   unsigned int offset_metadata;
-  uint64_t base __attribute__((aligned(8)));
-  uint64_t base_metadata __attribute__((aligned(8)));
-  uint64_t gpuaddr __attribute__((aligned(8)));
+  uint64_t base;
+  uint64_t base_metadata;
+  uint64_t gpuaddr;
 
   static const int kNumFds = 2;
   static const int kMagic = 'gmsm';
@@ -173,5 +174,6 @@
 
   uint64_t GetBackingstore() const { return id; }
 };
+#pragma pack(pop)
 
 #endif  // __GR_PRIV_HANDLE_H__