commit 9c0fe9145565c41dd749c12f131606c71626474f
author Linux Build Service Account <lnxbuild@localhost> Fri May 09 01:05:32 2014 -0700
committer Gerrit - the friendly Code Review server <code-review@localhost> Fri May 09 01:05:31 2014 -0700
tree 8f5fdaef71ea63093d458c8d86bdee5305253147
parent 98619d8897ed0bbe51146f760954a257d2db4d4e
parent 001b30942d137b532f25edecac34633612a31a0a

Merge "hqd: Fix Klocwork errors in liblight"

liblight/lights.c

diff --git a/liblight/lights.c b/liblight/lights.c
index 1aa0b58..6fd1290 100644
--- a/liblight/lights.c
+++ b/liblight/lights.c
@@ -83,7 +83,7 @@
     fd = open(path, O_RDWR);
     if (fd >= 0) {
         char buffer[20];
-        int bytes = sprintf(buffer, "%d\n", value);
+        int bytes = snprintf(buffer, sizeof(buffer), "%d\n", value);
         ssize_t amt = write(fd, buffer, (size_t)bytes);
         close(fd);
         return amt == -1 ? -errno : 0;
@@ -271,6 +271,10 @@
     pthread_once(&g_init, init_globals);
 
     struct light_device_t *dev = malloc(sizeof(struct light_device_t));
+
+    if(!dev)
+        return -ENOMEM;
+
     memset(dev, 0, sizeof(*dev));
 
     dev->common.tag = HARDWARE_DEVICE_TAG;