gralloc: Fix gralloc protected allocations
Protected allocations need to be uncached and don't need the MM
heap flag set
Change-Id: Ib64169e601af1c70a951a06266e70b4e18fc88f5
diff --git a/libgralloc/alloc_controller.cpp b/libgralloc/alloc_controller.cpp
index bebb6b4..cb1adec 100644
--- a/libgralloc/alloc_controller.cpp
+++ b/libgralloc/alloc_controller.cpp
@@ -88,11 +88,10 @@
* read or written in software. Any combination with a _RARELY_ flag will be
* treated as uncached. */
static bool useUncached(const int& usage) {
- if((usage & GRALLOC_USAGE_PRIVATE_UNCACHED) or
- ((usage & GRALLOC_USAGE_SW_WRITE_MASK) ==
- GRALLOC_USAGE_SW_WRITE_RARELY) or
- ((usage & GRALLOC_USAGE_SW_READ_MASK) ==
- GRALLOC_USAGE_SW_READ_RARELY))
+ if ((usage & GRALLOC_USAGE_PROTECTED) or
+ (usage & GRALLOC_USAGE_PRIVATE_UNCACHED) or
+ ((usage & GRALLOC_USAGE_SW_WRITE_MASK) == GRALLOC_USAGE_SW_WRITE_RARELY) or
+ ((usage & GRALLOC_USAGE_SW_READ_MASK) == GRALLOC_USAGE_SW_READ_RARELY))
return true;
return false;
diff --git a/libgralloc/gpu.cpp b/libgralloc/gpu.cpp
index 0eee65e..59dfce6 100644
--- a/libgralloc/gpu.cpp
+++ b/libgralloc/gpu.cpp
@@ -63,8 +63,7 @@
else
data.align = getpagesize();
- if ((usage & GRALLOC_USAGE_PROTECTED) &&
- (usage & GRALLOC_USAGE_PRIVATE_MM_HEAP)) {
+ if (usage & GRALLOC_USAGE_PROTECTED) {
if (usage & GRALLOC_USAGE_PRIVATE_SECURE_DISPLAY) {
/* The alignment here reflects qsee mmu V7L/V8L requirement */
data.align = SZ_2M;