commit f83d4480f2c7e37374c4516750aae79c6b12eb79
author Kinjal Bhavsar <kbhavsar@codeaurora.org> Wed Oct 10 15:56:21 2012 -0700
committer Iliyan Malchev <malchev@google.com> Fri Oct 12 16:15:31 2012 -0700
tree d55b460dd1dd0315623a948c86d3292d57e58266
parent 541b59d15504bb6e5b9fbeb031aa2287a1abed2a

HWC: Protect hwc_set from async events

Wait for hwc_set completion if already in progress before processing
the async events.

Bug: 7288769
Change-Id: Ibdd0ee82f079df566b899c94df19f6bb1031d686
Signed-off-by: Iliyan Malchev <malchev@google.com>

libhwcomposer/hwc.cpp

diff --git a/libhwcomposer/hwc.cpp b/libhwcomposer/hwc.cpp
index 1e66235..c510b66 100644
--- a/libhwcomposer/hwc.cpp
+++ b/libhwcomposer/hwc.cpp
@@ -278,7 +278,7 @@
 
 static int hwc_set_external(hwc_context_t *ctx,
         hwc_display_contents_1_t* list) {
-
+    Locker::Autolock _l(ctx->mExtSetLock);
     if(!ctx->overlayInUse[HWC_DISPLAY_EXTERNAL])
         ctx->mOverlay[HWC_DISPLAY_EXTERNAL]->setState(ovutils::OV_CLOSED);
 

libhwcomposer/hwc_uevents.cpp

diff --git a/libhwcomposer/hwc_uevents.cpp b/libhwcomposer/hwc_uevents.cpp
index a7f58ea..987957a 100644
--- a/libhwcomposer/hwc_uevents.cpp
+++ b/libhwcomposer/hwc_uevents.cpp
@@ -59,6 +59,7 @@
             ctx->mExtDisplay->setExternalDisplay(connected);;
         } else if(!(strncmp(str,"offline@",strlen("offline@")))) {
             connected = 0;
+            Locker::Autolock _l(ctx->mExtSetLock);
             ctx->mExtDisplay->setExternalDisplay(connected);;
         }
     }

libhwcomposer/hwc_utils.h

diff --git a/libhwcomposer/hwc_utils.h b/libhwcomposer/hwc_utils.h
index 9193540..ef2e3c8 100644
--- a/libhwcomposer/hwc_utils.h
+++ b/libhwcomposer/hwc_utils.h
@@ -212,6 +212,8 @@
 
     //Lock to prevent set from being called while blanking
     mutable Locker mBlankLock;
+    //Lock to protect set when detaching external disp
+    mutable Locker mExtSetLock;
     //Vsync
     struct vsync_state vstate;
 };