commit 201aca3682af60fbb4185926df4b18ab3d5d951c
author Sanket Padawe <sanketpadawe@google.com> Thu Jan 21 15:49:33 2016 -0800
committer Christopher N. Hesse <raymanfx@gmail.com> Wed Oct 12 12:56:19 2016 -0700
tree dc6d2c7140fa301a1e0b21d2288ac6f086b53373
parent e63b4f698635348b0bdd25cbf43beb59bcd1ce39

Use SimRefreshResponse struct in RIL Versions greater than 7

Modify condition to use SimRefreshResponse struct in
all RIL Versions greater than 7.

BUG=21075857

Change-Id: Ifde00434bfcaecf3b4c32392fc4964fe3b43f6b5

ril/libril/RilSapSocket.cpp

diff --git a/ril/libril/RilSapSocket.cpp b/ril/libril/RilSapSocket.cpp
index e422f34..19457f4 100644
--- a/ril/libril/RilSapSocket.cpp
+++ b/ril/libril/RilSapSocket.cpp
@@ -300,25 +300,26 @@
     SapSocketRequest* request= (SapSocketRequest*)t;
     MsgHeader *hdr = request->curr;
 
-    if (response && response_len > 0) {
-        MsgHeader rsp;
-        rsp.token = request->curr->token;
-        rsp.type = MsgType_RESPONSE;
-        rsp.id = request->curr->id;
-        rsp.error = (Error)e;
-        rsp.payload = (pb_bytes_array_t *)calloc(1,
-                sizeof(pb_bytes_array_t) + response_len);
-        if (!rsp.payload) {
-            RLOGE("onRequestComplete: OOM");
-        } else {
+    MsgHeader rsp;
+    rsp.token = request->curr->token;
+    rsp.type = MsgType_RESPONSE;
+    rsp.id = request->curr->id;
+    rsp.error = (Error)e;
+    rsp.payload = (pb_bytes_array_t *)calloc(1, sizeof(pb_bytes_array_t) + response_len);
+    if (!rsp.payload) {
+        RLOGE("onRequestComplete: OOM");
+    } else {
+        if (response && response_len > 0) {
             memcpy(rsp.payload->bytes, response, response_len);
             rsp.payload->size = response_len;
-
-            RLOGE("Token:%d, MessageId:%d", hdr->token, hdr->id);
-
-            sendResponse(&rsp);
-            free(rsp.payload);
+        } else {
+            rsp.payload->size = 0;
         }
+
+        RLOGE("Token:%d, MessageId:%d", hdr->token, hdr->id);
+
+        sendResponse(&rsp);
+        free(rsp.payload);
     }
 
     // Deallocate SapSocketRequest

ril/libril/ril.cpp

diff --git a/ril/libril/ril.cpp b/ril/libril/ril.cpp
index 2bb7684..fac9412 100755
--- a/ril/libril/ril.cpp
+++ b/ril/libril/ril.cpp
@@ -3267,7 +3267,7 @@
 
     startResponse;
     if (s_callbacks.version <= LAST_IMPRECISE_RIL_VERSION) {
-        if (s_callbacks.version == 7) {
+        if (s_callbacks.version >= 7) {
             responseSimRefreshV7(p, response);
         } else {
             int *p_cur = ((int *) response);