commit 2a40024127ef9af9c2633f07da93542ec570d181
author Basil Gello <vasek.gello@gmail.com> Tue Jul 18 22:00:01 2017 +0300
committer Christopher N. Hesse <raymanfx@gmail.com> Thu Aug 03 21:03:38 2017 +0000
tree b90d4bb22735be709d75443df92c41d4c95fd964
parent fb5669e851ba8e534fcf59ae36cd6228edaed35b

secril-client: close fds on I/O errors

if a kernel device returns an I/O error, it is better not to chew
the CPU resources retrying I/O operation on a not ready device.

Fixes periodical 100%-core load in audioserver after a voice call
completion.

Change-Id: I2b66ffd18c85823a11e50598a6b4e3c0245a0083

ril/libsecril-client/secril-client.cpp

diff --git a/ril/libsecril-client/secril-client.cpp b/ril/libsecril-client/secril-client.cpp
index a0bf078..e607f00 100755
--- a/ril/libsecril-client/secril-client.cpp
+++ b/ril/libsecril-client/secril-client.cpp
@@ -1141,6 +1141,12 @@
     FreeToken(&(client_prv->token_pool), token);
     ClearReqHistory(client_prv, token);
 
+    if (ret == -EPIPE || ret == -EBADFD) {
+        close(client_prv->sock);
+        client_prv->sock = -1;
+        client_prv->b_connect = 0;
+    }
+
     return RIL_CLIENT_ERR_UNKNOWN;
 }
 
@@ -1298,6 +1304,23 @@
                     client_prv->b_connect = 0;
                 }
             }
+        } else {
+            RLOGE("%s: select() returned %d\n", __FUNCTION__, -errno);
+
+            if (client_prv->sock > 0) {
+                close(client_prv->sock);
+                client_prv->sock = -1;
+                client_prv->b_connect = 0;
+            }
+
+            if (client_prv->p_rs)
+                record_stream_free(client_prv->p_rs);
+
+            // EOS
+            if (client_prv->err_cb) {
+                client_prv->err_cb(client_prv->err_cb_data, RIL_CLIENT_ERR_CONNECT);
+                return NULL;
+            }
         }
     }