commit a8fe2a112f1dd202172d08143afc0097e93e1318
author Christopher N. Hesse <raymanfx@gmail.com> Sat Dec 31 17:14:47 2016 +0100
committer Christopher N. Hesse <raymanfx@gmail.com> Sat Dec 31 17:14:47 2016 +0100
tree f370c09dbd2e31a10711c14a6d6262738034bae9
parent 34b8ed06f2ef469779d8ab9f055f9893f983ec5f

liblights: Check for hardware support on HAL open

Change-Id: I601a987914e1774c9d1d12574f143f19f22b12e9

liblights/lights.c

diff --git a/liblights/lights.c b/liblights/lights.c
index 0b82256..36a049b 100644
--- a/liblights/lights.c
+++ b/liblights/lights.c
@@ -38,6 +38,15 @@
 
 #define MAX_INPUT_BRIGHTNESS 255
 
+enum component_mask_t {
+    COMPONENT_BACKLIGHT = 0x1,
+    COMPONENT_BUTTON_LIGHT = 0x2,
+    COMPONENT_LED = 0x4,
+};
+
+// Assume backlight is always supported
+static int hw_components = COMPONENT_BACKLIGHT;
+
 static pthread_once_t g_init = PTHREAD_ONCE_INIT;
 static pthread_mutex_t g_lock = PTHREAD_MUTEX_INITIALIZER;
 
@@ -54,6 +63,14 @@
 static struct led_config g_leds[3]; // For battery, notifications, and attention.
 static int g_cur_led = -1;          // Presently showing LED of the above.
 
+void check_component_support()
+{
+    if (access(BUTTON_BRIGHTNESS_NODE, W_OK) == 0)
+        hw_components |= COMPONENT_BUTTON_LIGHT;
+    if (access(LED_BLINK_NODE, W_OK) == 0)
+        hw_components |= COMPONENT_LED;
+}
+
 void init_g_lock(void)
 {
     pthread_mutex_init(&g_lock, NULL);
@@ -287,21 +304,36 @@
 static int open_lights(const struct hw_module_t *module, char const *name,
                         struct hw_device_t **device)
 {
+    int requested_component;
     int (*set_light)(struct light_device_t *dev,
         struct light_state_t const *state);
 
-    if (0 == strcmp(LIGHT_ID_BACKLIGHT, name))
+    check_component_support();
+
+    if (0 == strcmp(LIGHT_ID_BACKLIGHT, name)) {
+        requested_component = COMPONENT_BACKLIGHT;
         set_light = set_light_backlight;
-    else if (0 == strcmp(LIGHT_ID_BUTTONS, name))
+    } else if (0 == strcmp(LIGHT_ID_BUTTONS, name)) {
+        requested_component = COMPONENT_BUTTON_LIGHT;
         set_light = set_light_buttons;
-    else if (0 == strcmp(LIGHT_ID_BATTERY, name))
+    } else if (0 == strcmp(LIGHT_ID_BATTERY, name)) {
+        requested_component = COMPONENT_LED;
         set_light = set_light_leds_battery;
-    else if (0 == strcmp(LIGHT_ID_NOTIFICATIONS, name))
+    } else if (0 == strcmp(LIGHT_ID_NOTIFICATIONS, name)) {
+        requested_component = COMPONENT_LED;
         set_light = set_light_leds_notifications;
-    else if (0 == strcmp(LIGHT_ID_ATTENTION, name))
+    } else if (0 == strcmp(LIGHT_ID_ATTENTION, name)) {
+        requested_component = COMPONENT_LED;
         set_light = set_light_leds_attention;
-    else
+    } else {
         return -EINVAL;
+    }
+
+    if ((hw_components & requested_component) == 0) {
+        ALOGV("%s: component 0x%x not supported by device", __func__,
+            requested_component);
+        return -EINVAL;
+    }
 
     int max_brightness = get_max_panel_brightness();
     if (max_brightness < 0) {