AOSP/DeskClock - Updated to sdkVersion 29.
+ Fixed all the comments from jplemieux@ in CL: https://android-review.googlesource.com/c/platform/packages/apps/DeskClock/+/1161143
+ Incorporated changes from Luca Stefani (https://android-review.googlesource.com/c/platform/packages/apps/DeskClock/+/1162919)
BUG: 133177396
BUG: 143990962
Test: manual - Tested the DeskClock UI manually and tested the alarm, stopwatch and timer.
$ make -j 40
$ ls -l out/target/product/generic/system/product/app/DeskClock/DeskClock.apk
-rw-r--r-- 1 rtenneti .... 6436375 Nov 11 16:09 out/target/product/generic/system/product/app/DeskClock/DeskClock.apk
$ adb install -r out/target/product/generic/system/product/app/DeskClock/DeskClock.apk
+ Verified by setting up the alaram and waiting for the alarm to go off.
"Clock has stopped" wasn't displayed. Noted there were no exceptions in the logs. (b/135587258)
++ The following are the results from logcat with manual alaram testing
On x20web site in my home directory - ~rtenneti/android/
logcat.out.1111.1610
logcat.out.1112.1603
++ Verified there were no java exceptions.
$ grep -n -i 'exception' ~rtenneti/android/logcat.out.1111.1610 | wc -l
0
++ Verified Alarm was firing (results are in x20web site)
$ grep -n -i 'alarm' ~rtenneti/android/logcat.out.1111.1610
(for an alarm that was set to 19:12:00 at 19:11:19. Results from Alarm firing).
6880:11-11 19:11:19.403 8813 8863 I AlarmClock: Registering instance: 1
6881:11-11 19:11:19.405 8813 8863 I AlarmClock: Setting high notification state to instance 1
6882:11-11 19:11:19.406 8813 8863 V AlarmClock: *** notifyChange() id: 1 url content://com.android.deskclock/instances/1
6883:11-11 19:11:19.408 8813 8863 V AlarmClock: Displaying high priority notification for alarm instance: 1
6884:11-11 19:11:19.414 8813 8863 I AlarmClock: Scheduling state change 5 to instance 1 at Mon 7:12 PM (1573517520000)
6885:11-11 19:11:19.419 8813 8863 I AlarmClock: Setting upcoming AlarmClockInfo for alarm: 1
6887:11-11 19:11:19.423 1329 1329 V SettingsProvider: Notifying for 0: content://settings/system/next_alarm_formatted
....
7143:11-11 19:12:00.031 1329 1329 V SettingsProvider: Notifying for 0: content://settings/system/next_alarm_formatted
7144:11-11 19:12:00.032 1329 1329 D ConditionProviders.SCP: onReceive android.app.action.NEXT_ALARM_CLOCK_CHANGED
....
7152:11-11 19:12:00.055 8813 8813 I AlarmClock: Setting fire state to instance 1
7153:11-11 19:12:00.105 8813 8813 V AlarmClock: *** notifyChange() id: 1 url content://com.android.deskclock/instances/1
7154:11-11 19:12:00.112 8813 8813 D Events : [Alarm] [Fire]
7155:11-11 19:12:00.113 8813 8813 I AlarmClock: Scheduling state change 6 to instance 1 at Mon 7:22 PM (1573518120000)
7156:11-11 19:12:00.118 8813 8813 I AlarmClock: Canceling upcoming AlarmClockInfo
7157:11-11 19:12:00.123 8813 8813 V AlarmClock: AlarmService.start with instance: 1
7158:11-11 19:12:00.124 8813 8813 V AlarmClock: Displaying alarm notification for alarm instance: 1
7159:11-11 19:12:00.130 8813 8813 V AlarmClock: Clearing notifications for alarm instance: 1
7161:11-11 19:12:00.145 8813 8813 V AlarmClock: AlarmKlaxon.start()
...
Change-Id: I005530d5d82568e028acb4cbad1f3212fc9c61a2
Signed-off-by: Jesse Chan <jc@lineageos.org>
5 files changed